Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16953 tests: fix btree parameter parsing #15897

Open
wants to merge 1 commit into
base: release/2.6
Choose a base branch
from

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Feb 13, 2025

Backoprt #15850

In btree.sh the -m and -t parameters were not applied correctly because of the preceding positional argument containing spaces but not wrapped in quotes

In btree.c an invalid parameter sequence was not detected due to of the partially manual parsing process.

All parameters parsing process has been unified.

Additionally:
instead of -t and -m parameters new parameters has been proposed:

-R[d] for class registration, optionally with dynamic root -M[p] for memory registration, optionally with indication to use persistent memory struct btr_test_state introduced to provide global parameters to the test (argc/argv) and avoid static variables for that purpose.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

In btree.sh the -m and -t parameters were not applied correctly because of the preceding positional argument containing spaces but not wrapped in quotes

In btree.c an invalid parameter sequence was not detected due to of the partially manual parsing process.

All parameters parsing process has been unified.

Additionally:
instead of -t and -m parameters new parameters has been proposed:

-R[d] for class registration, optionally with dynamic root
-M[p] for memory registration, optionally with indication to use persistent memory
struct btr_test_state introduced to provide global parameters to the test (argc/argv) and avoid static variables for that purpose.

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72 grom72 added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Feb 13, 2025
@grom72 grom72 requested a review from a team as a code owner February 13, 2025 11:09
Copy link

Ticket title is 'btree.sh argument parsing is off'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-16953

Copy link
Contributor

@jolivier23 jolivier23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but why do we need to backport a test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits
Development

Successfully merging this pull request may close these issues.

3 participants