DAOS-16876 vos: skip DTX record when load partial committed DTX - b26 #15882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ticket title is 'LRZ: m02r01s07dao engine coredumps with vos EMRG src/vos/ilog.c:411 ilog_open() Assertion' |
github-actions
bot
added
the
priority
Nasf-Fan
force-pushed
the
Nasf-Fan/DAOS-16876_3_b26
branch
from
0ecf0aa to
26c4ca1
Compare
NiuYawei
previously approved these changes
Feb 11, 2025
| @@ -2866,6 +2866,9 @@ vos_dtx_act_reindex(struct vos_container *cont) | |||
| dae->dae_need_release = 1; | |||
| D_INIT_LIST_HEAD(&dae->dae_link); | |||
|
|
|||
| if (DAE_FLAGS(dae) & DTE_PARTIAL_COMMITTED) | |||
| DAE_REC_CNT(dae) = 0; | |||
There was a problem hiding this comment.
The DAE_REC_CNT is supposed to be zero when the partial commit flag is set, so It's better to throw an error message when we hit non-zero record count for partial commit entry.
There was a problem hiding this comment.
At that time, no data corruption happened yet, so such error or warning may misguide the user.
Nasf-Fan
added
the
clean-cherry-pick
It is used to handle existing partial committed DTX records that were
generated when ran as DAOS-2.6.3-rc{1,2} to avoid repeated DTX commit
after engine restarted.
To be safe, it is required for the user/admin to explicitly set server
side environment variable "DAOS_SKIP_OLD_PARTIAL_DTX" when restart the
engine that has ever run as DAOS-2.6.3-rc{1,2}. If the user has never
used such version, such as directly upgrading from 2.6.1 to 2.6.3-rc3
or newer, then please do NOT set this environment variable.
Signed-off-by: Fan Yong <[email protected]>
Nasf-Fan
force-pushed
the
Nasf-Fan/DAOS-16876_3_b26
branch
from
26c4ca1 to
9346675
Compare
Nasf-Fan
removed
the
clean-cherry-pick
NiuYawei
approved these changes
Feb 11, 2025
gnailzenh
approved these changes
Feb 11, 2025
gnailzenh
approved these changes
Feb 11, 2025
This was referenced Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is used to handle existing partial committed DTX records that were
generated when ran as DAOS-2.6.3-rc{1,2} to avoid repeated DTX commit
after engine restarted.
To be safe, it is required for the user/admin to explicitly set server
side environment variable "DAOS_SKIP_OLD_PARTIAL_DTX" when restart the
engine that has ever run as DAOS-2.6.3-rc{1,2}. If the user has never
used such version, such as directly upgrading from 2.6.1 to 2.6.3-rc3
or newer, then please do NOT set this environment variable.
Before requesting gatekeeper:
Features:(orTest-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: