-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-17059 client: fcntl 3rd parameter should be void * #15856
Conversation
also need to return ENOTSUP for flock when compatible is not enabled Features: pil4dfs Signed-off-by: Lei Huang <[email protected]>
Ticket title is 'locking with fcntl() in libpil4dfs failed' |
Features: pil4dfs Signed-off-by: Lei Huang <[email protected]>
Features: pil4dfs Signed-off-by: Lei Huang <[email protected]>
src/client/dfuse/pil4dfs/int_dfs.c
Outdated
@@ -1,5 +1,6 @@ | |||
/** | |||
* (C) Copyright 2022-2024 Intel Corporation. | |||
* (C) Copyright 2022-2025 Intel Corporation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should revert the intel copyright update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All CI tests passed in build 3 without issue. The copyright was just fixed. "Doc-only: true" was set to avoid tests.
Doc-only: true Signed-off-by: Lei Huang <[email protected]>
Third argument is "void *" type in libc source code. "va_arg(arg, int);" leads to wrong argument retrieved. also need to return ENOTSUP for flock when compatible mode is not enabled.
Features: pil4dfs
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: