Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-17059 client: fcntl 3rd parameter should be void * #15856

Merged
merged 4 commits into from
Feb 8, 2025

Conversation

wiliamhuang
Copy link
Contributor

@wiliamhuang wiliamhuang commented Feb 7, 2025

Third argument is "void *" type in libc source code. "va_arg(arg, int);" leads to wrong argument retrieved. also need to return ENOTSUP for flock when compatible mode is not enabled.

Features: pil4dfs

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

also need to return ENOTSUP for flock when compatible is not enabled

Features: pil4dfs

Signed-off-by: Lei Huang <[email protected]>
@wiliamhuang wiliamhuang requested review from a team as code owners February 7, 2025 05:07
Copy link

github-actions bot commented Feb 7, 2025

Ticket title is 'locking with fcntl() in libpil4dfs failed'
Status is 'Open'
Labels: 'intercept_lib,request_for_2.6.3'
https://daosio.atlassian.net/browse/DAOS-17059

Features: pil4dfs

Signed-off-by: Lei Huang <[email protected]>
Features: pil4dfs

Signed-off-by: Lei Huang <[email protected]>
@@ -1,5 +1,6 @@
/**
* (C) Copyright 2022-2024 Intel Corporation.
* (C) Copyright 2022-2025 Intel Corporation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should revert the intel copyright update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All CI tests passed in build 3 without issue. The copyright was just fixed. "Doc-only: true" was set to avoid tests.

Doc-only: true

Signed-off-by: Lei Huang <[email protected]>
@wiliamhuang wiliamhuang requested a review from mchaarawi February 8, 2025 05:05
@wiliamhuang wiliamhuang requested a review from a team February 8, 2025 20:13
@mchaarawi mchaarawi merged commit 01406c9 into master Feb 8, 2025
39 checks passed
@mchaarawi mchaarawi deleted the lei/DAOS-17059 branch February 8, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants