Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-17055 client: add a soft limit of 16k to nr ranges for list-io #15854

Merged
merged 1 commit into from
Feb 11, 2025
Merged

DAOS-17055 client: add a soft limit of 16k to nr ranges for list-io #15854

merged 1 commit into from
Feb 11, 2025
+110 −6

Conversation

mchaarawi
Copy link
Contributor

@mchaarawi mchaarawi commented Feb 6, 2025 •
edited
Loading

For dfs_readx/writex and array_read/write operations, add a limit for the number of IODs being passed to DAOS of 16k if the iod rexc sizes are smaller than 16 bytes.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

Ticket title is 'add a soft limit to list-io on the client side for IOD nrs.'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-17055

@mchaarawi mchaarawi force-pushed the mschaara/list_io_limit branch 2 times, most recently from e858cb9 to cd911f4 Compare February 6, 2025 20:42
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15854/5/testReport/

@mchaarawi mchaarawi force-pushed the mschaara/list_io_limit branch from cd911f4 to e671297 Compare February 7, 2025 15:12
@mchaarawi mchaarawi changed the title DAOS-17055 client: add a soft limit of 64 to nr ranges for list-io DAOS-17055 client: add a soft limit of 4k to nr ranges for list-io Feb 7, 2025
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15854/6/testReport/

mchaarawi
mchaarawi commented Feb 8, 2025
View reviewed changes
src/include/daos_fs.h Outdated
@@ -623,7 +624,7 @@ dfs_read(dfs_t *dfs, dfs_obj_t *obj, d_sg_list_t *sgl, daos_off_t off,
*
* \param[in] dfs Pointer to the mounted file system.
* \param[in] obj Opened file object.
* \param[in] iod IO descriptor for list-io.
* \param[in] iod IO descriptor for list-io (limit of 64 ranges).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i need to change that comment to 4k. will do it after all tests run with no testing.

mchaarawi
mchaarawi commented Feb 8, 2025
View reviewed changes
src/include/daos_fs.h Outdated
@@ -657,7 +658,7 @@ dfs_write(dfs_t *dfs, dfs_obj_t *obj, d_sg_list_t *sgl, daos_off_t off,
*
* \param[in] dfs Pointer to the mounted file system.
* \param[in] obj Opened file object.
* \param[in] iod IO descriptor of file view.
* \param[in] iod IO descriptor for list-io (limit of 64 ranges).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i need to change that comment to 4k. will do it after all tests run with no testing.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15854/7/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15854/7/testReport/

@mchaarawi mchaarawi force-pushed the mschaara/list_io_limit branch 2 times, most recently from 77de09d to 3e2fd93 Compare February 8, 2025 18:17
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15854/9/testReport/

@mchaarawi mchaarawi force-pushed the mschaara/list_io_limit branch 2 times, most recently from 449dd2d to fb5e2af Compare February 10, 2025 15:35
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15854/11/display/redirect

@mchaarawi mchaarawi force-pushed the mschaara/list_io_limit branch from fb5e2af to 1ce3f51 Compare February 10, 2025 16:35
@mchaarawi
DAOS-17055 client: add a soft limit of 4k to nr ranges for list-io
0faab49 
For dfs_readx/writex and array_read/write operations, add a limit for
the number of IODs being passed to DAOS of 16k if the range lengths are
under 16 bytes (best effort checking).

Features: dfs
Signed-off-by: Mohamad Chaarawi <[email protected]>
@mchaarawi mchaarawi force-pushed the mschaara/list_io_limit branch from 1ce3f51 to 0faab49 Compare February 10, 2025 17:00
@daosbuild1
Copy link
Collaborator

Test stage Unit Test bdev with memcheck on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15854/13/display/redirect

@mchaarawi mchaarawi changed the title DAOS-17055 client: add a soft limit of 4k to nr ranges for list-io DAOS-17055 client: add a soft limit of 16k to nr ranges for list-io Feb 10, 2025
@mchaarawi mchaarawi marked this pull request as ready for review February 10, 2025 18:22
@mchaarawi mchaarawi requested review from a team as code owners February 10, 2025 18:22
knard38
knard38 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@phender phender merged commit 9faf4aa into master Feb 11, 2025
59 checks passed
@phender phender deleted the mschaara/list_io_limit branch February 11, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnailzenh gnailzenh gnailzenh approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

@wiliamhuang wiliamhuang wiliamhuang approved these changes

@knard38 knard38 knard38 approved these changes

@johannlombardi johannlombardi Awaiting requested review from johannlombardi

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mchaarawi @daosbuild1 @gnailzenh @daltonbohning @wiliamhuang @knard38 @phender