Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-17003 container: use thread instead of task #15845

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

NiuYawei
Copy link
Contributor

@NiuYawei NiuYawei commented Feb 5, 2025

Use ABT thread instead of ABT task for cont_refresh_track_eph_one(), since local tx is used in the function which yield in md-on-ssd mode.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Use ABT thread instead of ABT task for cont_refresh_track_eph_one(),
since local tx is used in the function which yield in md-on-ssd mode.

Signed-off-by: Niu Yawei <[email protected]>
@NiuYawei NiuYawei requested review from a team as code owners February 5, 2025 02:47
Copy link

github-actions bot commented Feb 5, 2025

Ticket title is 'aggregation/basic.py:DaosAggregationBasic.test_basic_aggregation - wait_tx_committed() Assertion 'd_list_empty(&wal_tx->td_link)' failed'
Status is 'In Review'
Labels: 'ci_master_daily,closed-master,md_on_ssd,pr_test'
https://daosio.atlassian.net/browse/DAOS-17003

@NiuYawei NiuYawei requested review from liuxuezhao, Nasf-Fan, sherintg, jolivier23 and phender and removed request for a team February 5, 2025 02:55
@phender
Copy link
Contributor

phender commented Feb 5, 2025

The following commit pragmas are required to run tests with md on ssd enabled as the stages are disabled for PRs by default:

Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-large-md-on-ssd: false

For future reference these can be found in https://daosio.atlassian.net/wiki/spaces/DC/pages/11891933554/Commit+Pragmas

Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-large-md-on-ssd: false

Signed-off-by: Niu Yawei <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15845/2/execution/node/1550/log

Copy link
Contributor

@liuxuezhao liuxuezhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, thanks for the fix

@gnailzenh gnailzenh merged commit e24bb62 into master Feb 7, 2025
57 of 59 checks passed
@gnailzenh gnailzenh deleted the niu/DAOS-17003 branch February 7, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants