Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16469 engine: bind helper - b26 #15307

Open
wants to merge 1 commit into
base: release/2.6
Choose a base branch
from

Conversation

Nasf-Fan
Copy link
Contributor

When a main IO XS wants to add some task to helper XS (in spite of via chore queue or creating new ULT), it needs to take lock on related helper XS. Under the dss_helper_pool mode, if there are a lot of ULTs from different main IO XS doing that concurrently, the overhead caused by lock contention may be high. To reduce such overhead, we will divide main IO XS into small groups, and bind each group to a helper XS: the ones in the same group will share one helper, different groups use different helpers. Then above lock contention will be restricted inside the group. Depends on the system configuration, such solution may be unnecessary, for example, there is only single helper per engine, or very limited targets (less than 4 or about) per engine. So this feature will be configurable via environment variable DAOS_BIND_HELPER that is unset by default.

NOTE:

  1. Binding helper is only available when the count of helper XS is non-zero and smaller than the count of main IO XS.
  2. If multiple sockets mode is enabled (dss_numa_nr > 1), then do not bind helper for simplification.
  3. To be load balanced, if the count of main IO XS is not the integral multiple of the helper XS, then binding helper will be disabled automatically.

Allow-unstable-test: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Copy link

github-actions bot commented Oct 13, 2024

Ticket title is 'IOR Easy performance low with EC_16P2GX'
Status is 'In Progress'
Labels: 'daos_ecb_scale,pre_acceptance_issues'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16469

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16469_5_b26 branch from 9627e2c to 175d853 Compare October 15, 2024 10:32
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15307/2/execution/node/1550/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16469_5_b26 branch 3 times, most recently from f10ce8a to 54e3af4 Compare October 21, 2024 02:16
@daosbuild1
Copy link
Collaborator

Test stage Unit Test bdev on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15307/5/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15307/5/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15307/5/display/redirect

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16469_5_b26 branch from 54e3af4 to 27fcff8 Compare October 21, 2024 16:40
@Nasf-Fan Nasf-Fan marked this pull request as ready for review October 23, 2024 01:40
@Nasf-Fan Nasf-Fan requested review from a team as code owners October 23, 2024 01:40
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16469_5_b26 branch 2 times, most recently from 48baa9b to f68d151 Compare October 24, 2024 06:28
When a main IO XS wants to add some task to helper XS (in spite of via chore
queue or creating new ULT), it needs to take lock on related helper XS. Under
the dss_helper_pool mode, if there are a lot of ULTs from different main IO XS
doing that concurrently, the overhead caused by lock contention may be high. To
reduce such overhead, we will divide main IO XS into small groups, and bind each
group to a helper XS: the ones in the same group will share one helper, different
groups use different helpers. Then above lock contention will be restricted inside
the group. Depends on the system configuration, such solution may be unnecessary,
for example, there is only single helper per engine, or very limited targets (less
than 4 or about) per engine. So this feature will be configurable via environment
variable DAOS_BIND_HELPER that is unset by default.

NOTE:

1. Binding helper is only available when the count of helper XS is non-zero and
   smaller than the count of main IO XS.
2. If multiple sockets mode is enabled (dss_numa_nr > 1), then do not bind helper
   for simplification.
3. To be load balanced, if the count of main IO XS is not the integral multiple
   of the helper XS, then binding helper will be disabled automatically.

Allow-unstable-test: true

Signed-off-by: Fan Yong <[email protected]>
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16469_5_b26 branch from f68d151 to ad6a15c Compare October 25, 2024 01:01
@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Ticket has high priority (automatically managed)
Development

Successfully merging this pull request may close these issues.

2 participants