Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15817 test: raise exception for clush job_manager failure #14345

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DAOS-15817 test: raise exception for clush job_manager failure #14345

wants to merge 2 commits into from

Conversation

daltonbohning
Copy link
Contributor

@daltonbohning daltonbohning commented May 10, 2024 •
edited
Loading

Raise an exception when the clush job_manager run fails.
Fix ior usage server/metadata.py since it was previously silently failing.

Test-tag: ObjectMetadata DaosCoreTestDfuse
Skip-unit-tests: true
Skip-fault-injection-test: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this May 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 10, 2024 •
edited
Loading

Ticket title is 'server/metadata.py:ObjectMetadata.test_metadata_server_restart - ior: command not found false pass'
Status is 'In Review'
Labels: 'ci_impact,scrubbed_2.8,triaged,weekly_test'
https://daosio.atlassian.net/browse/DAOS-15817

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14345/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14345/2/testReport/

@daltonbohning daltonbohning force-pushed the dbohning/daos-15817 branch from a23b69b to 9b61bdd Compare May 13, 2024 16:54
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14345/3/testReport/

@daltonbohning daltonbohning force-pushed the dbohning/daos-15817 branch 2 times, most recently from 34bdfa2 to ad01f71 Compare May 14, 2024 16:00
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14345/5/testReport/

@daltonbohning daltonbohning force-pushed the dbohning/daos-15817 branch from ad01f71 to a9de2d3 Compare May 14, 2024 17:19
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14345/6/testReport/

@daltonbohning daltonbohning force-pushed the dbohning/daos-15817 branch from a9de2d3 to 7e0ea5d Compare May 15, 2024 14:50
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14345/7/testReport/

@daltonbohning daltonbohning force-pushed the dbohning/daos-15817 branch 3 times, most recently from 3c06452 to 1ae48ba Compare May 17, 2024 17:42
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14345/10/testReport/

@daltonbohning daltonbohning force-pushed the dbohning/daos-15817 branch 2 times, most recently from b244731 to c66c899 Compare May 21, 2024 20:17
@daltonbohning daltonbohning force-pushed the dbohning/daos-15817 branch from c66c899 to 7687036 Compare May 28, 2024 18:25
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14345/15/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14345/16/execution/node/922/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14345/17/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14345/18/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14345/19/execution/node/922/log

@daltonbohning daltonbohning force-pushed the dbohning/daos-15817 branch 2 times, most recently from ab93afd to c56dedb Compare January 7, 2025 23:20
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14345/21/execution/node/926/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14345/22/execution/node/925/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14345/23/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14345/24/execution/node/925/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-14345/25/testReport/

@daltonbohning
DAOS-15817 test: raise exception for clush job_manager failure
3d10437 
Raise an exception when the clush job_manager run fails.
Fix ior usage server/metadata.py since it was previously silently failing.

Test-tag: ObjectMetadata DaosCoreTestDfuse
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning marked this pull request as ready for review February 26, 2025 23:17
@daltonbohning daltonbohning requested review from a team as code owners February 26, 2025 23:17
phender
phender previously approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@phender phender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major.

@daltonbohning
review feedback
846bc30 
Test-tag: ObjectMetadata DaosCoreTestDfuse
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Dalton Bohning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shimizukko shimizukko shimizukko approved these changes

@phender phender phender approved these changes

@rpadma2 rpadma2 Awaiting requested review from rpadma2

@dinghwah dinghwah Awaiting requested review from dinghwah

Assignees

@daltonbohning daltonbohning

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daltonbohning @daosbuild1 @shimizukko @phender