Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run the RPM build and test on workflow_dispatch #14177

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Run the RPM build and test on workflow_dispatch #14177

wants to merge 4 commits into from

Conversation

brianjmurrell
Copy link
Contributor

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@brianjmurrell brianjmurrell self-assigned this Apr 17, 2024
@github-actions GitHub Actions
Copy link

Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/Run

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 17, 2024
View reviewed changes
.github/workflows/rpm-build-and-test.yml
@@ -404,8 +430,16 @@
QUEUE_URL:
LABEL:
steps:
- name: Checkout code
uses: actions/checkout@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: GitHub-owned GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/rpm-build-and-test.yml
@@ -638,8 +671,16 @@
QUEUE_URL:
LABEL:
steps:
- name: Checkout code
uses: actions/checkout@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: GitHub-owned GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/rpm-build-and-test.yml Outdated
outputs:
matrix: ${{ steps.matrix.outputs.text }}
steps:
- name: Checkout code
uses: actions/checkout@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: GitHub-owned GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/rpm-build-and-test.yml Outdated
@@ -193,8 +212,14 @@
DISTRO_VERSION:
CP_LEAP15_VERSION:
steps:
- name: Checkout code
uses: actions/checkout@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: GitHub-owned GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
@brianjmurrell brianjmurrell force-pushed the bmurrell/run-on-dispatch branch 2 times, most recently from 0bed0d8 to e6f70e3 Compare April 22, 2024 19:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

Functional on EL 9 Test Results (old)

 6 tests   6 ✅  3m 48s ⏱️
12 suites  0 💤
12 files    0 ❌

Results for commit d9d2981.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

Functional on EL 8.8 Test Results (old)

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit f0b45bb.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

Functional on Leap 15.5 Test Results (old)

 6 tests   6 ✅  3m 50s ⏱️
12 suites  0 💤
12 files    0 ❌

Results for commit d9d2981.

♻️ This comment has been updated with latest results.

@brianjmurrell brianjmurrell force-pushed the bmurrell/run-on-dispatch branch from 703488a to 897c5c3 Compare April 24, 2024 16:28
@brianjmurrell brianjmurrell force-pushed the bmurrell/run-on-dispatch branch 2 times, most recently from 4a1670d to 209e0c2 Compare July 8, 2024 17:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

Functional on EL 8.8 Test Results

133 tests   129 ✅  1h 23m 13s ⏱️
 42 suites    4 💤
 42 files      0 ❌

Results for commit f77896a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

Functional on EL 9 Test Results

133 tests   128 ✅  1h 35m 26s ⏱️
 42 suites    4 💤
 42 files      1 ❌

For more details on these failures, see this check.

Results for commit 0535410.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

Functional on Leap 15.5 Test Results

133 tests   129 ✅  1h 28m 54s ⏱️
 42 suites    4 💤
 42 files      0 ❌

Results for commit f77896a.

♻️ This comment has been updated with latest results.

@brianjmurrell brianjmurrell mentioned this pull request Oct 15, 2024
Closed
18 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 15, 2024
View reviewed changes
.github/workflows/rpm-build-and-test.yml
- name: Checkout code
uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Import commit pragmas
uses: daos-stack/action-import-commit-pragmas@v1

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/rpm-build-and-test.yml
- name: Import commit pragmas
uses: ./.github/actions/import-commit-pragmas
uses: daos-stack/action-import-commit-pragmas@v1

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/rpm-build-and-test.yml
- name: Checkout code
uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Import commit pragmas
uses: daos-stack/action-import-commit-pragmas@v1

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/rpm-build-and-test.yml
- name: Import commit pragmas
uses: ./.github/actions/import-commit-pragmas
uses: daos-stack/action-import-commit-pragmas@v1

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
@brianjmurrell brianjmurrell force-pushed the bmurrell/run-on-dispatch branch 2 times, most recently from e9e3010 to b622902 Compare October 21, 2024 19:19
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 21, 2024
View reviewed changes
.github/workflows/bullseye-coverage.yml
matrix: ${{ steps.matrix.outputs.text }}
steps:
- name: Checkout code
uses: actions/checkout@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: GitHub-owned GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/bullseye-coverage.yml
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Import commit pragmas
uses: daos-stack/action-import-commit-pragmas@v1

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/bullseye-coverage.yml
COMMIT_STATUS_DISTRO_VERSION:
steps:
- name: Checkout code
uses: actions/checkout@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: GitHub-owned GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/bullseye-coverage.yml
fetch-depth: 500
ref: ${{ github.event.pull_request.head.sha }}
- name: Import commit pragmas
uses: daos-stack/action-import-commit-pragmas@v1

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/bullseye-coverage.yml
- name: Publish test results
if: (!cancelled()) && (success() || failure()) &&
steps.run-test.outcome != 'skipped'
uses: EnricoMi/publish-unit-test-result-action@v2

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 1: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/bullseye-coverage.yml
fetch-depth: 500
ref: ${{ github.event.pull_request.head.sha }}
- name: Import commit pragmas
uses: daos-stack/action-import-commit-pragmas@v1

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/bullseye-coverage.yml
- name: Publish test results
if: (!cancelled()) && (success() || failure()) &&
steps.run-test.outcome != 'skipped'
uses: EnricoMi/publish-unit-test-result-action@v2

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 1: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/bullseye-coverage.yml
- name: Publish artifacts
if: (!cancelled()) && (success() || failure()) &&
steps.run-test.outcome != 'skipped'
uses: actions/upload-artifact@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: GitHub-owned GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/bullseye-coverage.yml
- name: Upload test results
if: (success() || failure()) &&
steps.run-test.outcome != 'skipped'
uses: actions/upload-artifact@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: GitHub-owned GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/bullseye-coverage.yml
path: ${{ env.STAGE_NAME }}/**/results.xml
- name: Update commit status
if: contains(fromJSON('["push", "pull_request"]'), github.event_name)
uses: ouzi-dev/commit-status-updater@v2

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

Functional Hardware Medium Verbs Provider Test Results

28 tests   28 ✅  16s ⏱️
 7 suites   0 💤
 7 files     0 ❌

Results for commit f77896a.

♻️ This comment has been updated with latest results.

@brianjmurrell brianjmurrell force-pushed the bmurrell/run-on-dispatch branch from 507aab4 to 82869e6 Compare November 27, 2024 15:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Functional Hardware Large Test Results

52 tests   52 ✅  20s ⏱️
11 suites   0 💤
11 files     0 ❌

Results for commit f77896a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Functional Hardware Medium Test Results

132 tests   105 ✅  2h 9m 55s ⏱️
 35 suites   27 💤
 35 files      0 ❌

Results for commit f77896a.

♻️ This comment has been updated with latest results.

@brianjmurrell brianjmurrell force-pushed the bmurrell/run-on-dispatch branch from 8003a30 to 0535410 Compare December 2, 2024 15:11
@brianjmurrell
Big refactor of GHA workflows
f77896a 
Add the use of reusable workflows and actions to reduce the amount of
duplicated code in this repository as well as dependency repositories.

Run-GHA: true
Skip-PR-comments: true
Test-tag: always_passes

Signed-off-by: Brian J. Murrell <[email protected]>
@brianjmurrell brianjmurrell force-pushed the bmurrell/run-on-dispatch branch from 0535410 to f77896a Compare December 2, 2024 20:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Functional on EL 9.4 Test Results

133 tests   128 ✅  1h 35m 27s ⏱️
 42 suites    4 💤
 42 files      1 ❌

For more details on these failures, see this check.

Results for commit f77896a.

@brianjmurrell
Use organizational and repository variables
bca00f8 
Run-GHA: true
Skip-PR-comments: true
Test-tag: always_passes

Required-githooks: true
Signed-off-by: Brian J. Murrell <[email protected]>
@brianjmurrell
Fix
db38fee 
Run-GHA: true
Skip-PR-comments: true
Test-tag: always_passes

Required-githooks: true

Signed-off-by: Brian J. Murrell <[email protected]>
@brianjmurrell
Strings are not cast to boolean, sadly
eb66d57 
Run-GHA: true
Skip-PR-comments: true
Test-tag: always_passes

Required-githooks: true

Signed-off-by: Brian J. Murrell <[email protected]>
@brianjmurrell brianjmurrell marked this pull request as ready for review December 3, 2024 18:39
@brianjmurrell brianjmurrell requested a review from a team as a code owner December 3, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brianjmurrell brianjmurrell

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brianjmurrell