DAOS-15050 dtx: replace D_INFO with D_DEBUG for debug message #13643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bug-tracker data: |
Nasf-Fan
force-pushed
the
Nasf-Fan/DAOS-15050
branch
from
0763385 to
f471280
Compare
mchaarawi
reviewed
Jan 22, 2024
src/dtx/dtx_rpc.c
Outdated
| @@ -1101,7 +1101,7 @@ dtx_refresh_internal(struct ds_cont_child *cont, int *check_count, d_list_t *che | |||
| if (rc1 != DTX_ST_COMMITTED && rc1 != DTX_ST_ABORTED && | |||
| rc1 != -DER_NONEXIST) { | |||
| if (!for_io) | |||
| D_INFO("Hit some long-time DTX "DF_DTI", %d\n", | |||
| D_WARN("Hit some long-time DTX "DF_DTI", %d\n", | |||
There was a problem hiding this comment.
does this really need to be a warning?
everything about his PR is making things debug, but this is going the other way :-)
There was a problem hiding this comment.
The long-time DTX is unexpected, there may be some bad things happened, generate warning message to reminder the user.
Nasf-Fan
force-pushed
the
Nasf-Fan/DAOS-15050
branch
from
f471280 to
93424bf
Compare
|
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13643/3/execution/node/1387/log |
To avoid noisy dtx related message when open/close the container. Required-githooks: true Signed-off-by: Fan Yong <[email protected]>
Nasf-Fan
force-pushed
the
Nasf-Fan/DAOS-15050
branch
from
93424bf to
6803b5a
Compare
liuxuezhao
approved these changes
Jan 26, 2024
mchaarawi
approved these changes
Jan 26, 2024
|
Ping @daos-stack/daos-gatekeeper , thanks! |
|
please port to 2.4 |
brianjmurrell
pushed a commit
that referenced
this pull request
Jan 31, 2024
To avoid noisy dtx related message when open/close the container. #Pragmas from previous commit message: Skip-checkpatch: true Skip-python-bandit: true Skip-build: true Quick-build: true Quick-Functional: true Allow-unstable-test: true #RPM-test-version: version[-release] #RPM-test-version: 2.5.100 # VM1-label: ci_vm1 # Ubuntu-VM9-label: ci_vm9 # Leap15-VM9-label: ci_vm9 # EL8-VM9-label: ci_vm9 # HW-medium-label: ci_nvme5 # HW-large-label: ci_nvme9 Signed-off-by: Fan Yong <[email protected]>
Nasf-Fan
added a commit
that referenced
this pull request
Feb 1, 2024
To avoid noisy dtx related message when open/close the container. Signed-off-by: Fan Yong <[email protected]>
mchaarawi
pushed a commit
that referenced
this pull request
Feb 5, 2024
#13716) To avoid noisy dtx related message when open/close the container. Signed-off-by: Fan Yong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid noisy dtx related message when open/close the container.
Required-githooks: true
Before requesting gatekeeper:
Features:(orTest-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: