DAOS-14909 pool: property for rdb svc_ops KVS entry max age #13639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenneth Cain <[email protected]>
- DAOS_MD_OPS_AGE_SEC environment variable to specify a maximum age of svc_ops KVS entries (if default 300 seconds is insufficient). - test-only pool property "svc_ops_enabled" that can take on the boolean values 0 (disabled) or 1 (enabled). So that tests may create pools without the duplicate operations detection feature. Signed-off-by: Kenneth Cain <[email protected]>
Signed-off-by: Kenneth Cain <[email protected]>
Signed-off-by: Kenneth Cain <[email protected]>
since co_op_retry() is taking about a minute longer due to several raft elections called as part of the test. Test-tag: test_daos_container Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Kenneth Cain <[email protected]>
Signed-off-by: Kenneth Cain <[email protected]>
|
Bug-tracker data: |
kccain
force-pushed
the
kccain/daos_14909
branch
from
2d7a3b7 to
e76ac2f
Compare
|
Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13639/2/testReport/ |
kccain
force-pushed
the
kccain/daos_14909
branch
from
e76ac2f to
c5b351b
Compare
|
Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13639/3/testReport/ |
|
Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13639/3/execution/node/1187/log |
Features: pool
To specify the maximum age of an entry in the svc_ops KVS (that is within rdb, and used for duplicate operation detection), this change introduces a pool property, DAOS_PROP_PO_SVC_OPS_ENTRY_AGE. This replaces the previous engine environment variable interface. The property may be specified during pool create and is then immutable. The default max age is 300 seconds, with a valid range of 150-600. Features: pool Signed-off-by: Kenneth Cain <[email protected]>
kccain
force-pushed
the
kccain/daos_14909
branch
from
a2ab43c to
fb948e4
Compare
Features: pool
kccain
requested review from
mjmac,
tanabarr and
liw
and removed request for
a team
mjmac
approved these changes
Jan 25, 2024
| @@ -120,6 +120,31 @@ func PoolProperties() PoolPropertyMap { | |||
| valueMarshaler: numericMarshaler, | |||
| }, | |||
| }, | |||
| "svc_ops_entry_age": { | |||
There was a problem hiding this comment.
Would be a good idea to add some test cases for this to TestControl_PoolProperties. Looks like the svc_ops_enabled property could use some, too.
There was a problem hiding this comment.
I have a separate PR with some candidate unit test cases for these two new properties, #13676
liw
approved these changes
Jan 26, 2024
brianjmurrell
pushed a commit
that referenced
this pull request
Jan 31, 2024
To specify the maximum age of an entry in the svc_ops KVS (that is within rdb, and used for duplicate operation detection), this change introduces a pool property, DAOS_PROP_PO_SVC_OPS_ENTRY_AGE. This replaces the previous engine environment variable interface. The property may be specified during pool create and is then immutable. The default max age is 300 seconds, with a valid range of 150-600. #Pragmas from previous commit message: Skip-checkpatch: true Skip-python-bandit: true Skip-build: true Quick-build: true Quick-Functional: true Allow-unstable-test: true #RPM-test-version: version[-release] #RPM-test-version: 2.5.100 # VM1-label: ci_vm1 # Ubuntu-VM9-label: ci_vm9 # Leap15-VM9-label: ci_vm9 # EL8-VM9-label: ci_vm9 # HW-medium-label: ci_nvme5 # HW-large-label: ci_nvme9 Signed-off-by: Kenneth Cain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To specify the maximum age of an entry in the svc_ops KVS (that is within rdb, and used for duplicate operation detection), this change introduces a pool property, DAOS_PROP_PO_SVC_OPS_ENTRY_AGE. This replaces the previous engine environment variable interface. The property may be specified during pool create and is then immutable. The default max age is 300 seconds, with a valid range of 150-600.
Features: pool
Before requesting gatekeeper:
Features:(orTest-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: