DAOS-15041 bio: handle normal device hot remove #13635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a normal device is hot removed before being marked as faulty, the faulty reaction won't be performed, so that we need to close opened blobs when teardown the device, at the same time, the closed blobs need be opened on setup when the normal device is plugged back (in which case reint won't be triggered). Signed-off-by: Niu Yawei <[email protected]>
|
Bug-tracker data: |
liuxuezhao
approved these changes
Jan 19, 2024
tanabarr
reviewed
Jan 19, 2024
shimizukko
approved these changes
Jan 20, 2024
|
Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13635/1/testReport/ |
wangshilong
reviewed
Jan 22, 2024
| } | ||
|
|
||
| if (closed_blobs) { | ||
| D_DEBUG(DB_MGMT, "blobstore:%p has %d closed blobs\n", |
There was a problem hiding this comment.
maybe a assertion D_ASSERT(bxb->bxb_ready == true).
There was a problem hiding this comment.
why? the bxb_ready should be false in this case.
wangshilong
reviewed
Jan 22, 2024
| bio_blob_close(ioc, true); | ||
| } | ||
|
|
||
| if (opened_blobs) { |
There was a problem hiding this comment.
[Question]when we will free io_channel?
There was a problem hiding this comment.
When all opened blobs are closed, it could move on to putting io channel (see following code).
wangshilong
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a normal device is hot removed before being marked as faulty, the faulty reaction won't be performed, so that we need to close opened blobs when teardown the device, at the same time, the closed blobs need be opened on setup when the normal device is plugged back (in which case reint won't be triggered).
Before requesting gatekeeper:
Features:(orTest-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: