-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-15031 test: launch.py: exit early if extra yaml is not a file #13624
Conversation
Bug-tracker data: |
@phender The benefit of this approach is that it exits as early as possible and is simple. But it will not create a job.log in the event of failure. E.g.
But this is inline with other invalid arguments. E.g.
|
9ec2b94
to
488dbea
Compare
Test-tag: test_always_passes test_soak_smoke Skip-unit-tests: true Skip-fault-injection-test: true Exit as early as possible if extra yaml is not a file. Also convert servers and clients to a NodeSet early. Also parse --logs_threshold early Required-githooks: true Signed-off-by: Dalton Bohning <[email protected]>
488dbea
to
b4fd76f
Compare
Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13624/7/execution/node/973/log |
soak_smoke failure is |
d7f7c1e
to
3df85e1
Compare
Test-tag: pr,vm test_soak_smoke Skip-unit-tests: true Skip-fault-injection-test: true Based on find -size https://man7.org/linux/man-pages/man1/find.1.html Required-githooks: true Signed-off-by: Dalton Bohning <[email protected]>
3df85e1
to
825fd29
Compare
Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13624/10/execution/node/974/log |
…13624) Test-tag: pr,vm test_soak_smoke Skip-unit-tests: true Skip-fault-injection-test: true Exit as early as possible if extra yaml is not a file. Also convert servers and clients to a NodeSet early. Also parse --logs_threshold early Required-githooks: true Signed-off-by: Dalton Bohning <[email protected]>
…13624) (#13683) Exit as early as possible if extra yaml is not a file. Also convert servers and clients to a NodeSet early. Also parse --logs_threshold early Signed-off-by: Dalton Bohning <[email protected]>
Test-tag: test_always_passes
Skip-unit-tests: true
Skip-fault-injection-test: true
Exit as early as possible if extra yaml is not a file.
Required-githooks: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: