Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15031 test: launch.py: exit early if extra yaml is not a file #13624

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

daltonbohning
Copy link
Contributor

Test-tag: test_always_passes
Skip-unit-tests: true
Skip-fault-injection-test: true

Exit as early as possible if extra yaml is not a file.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Jan 17, 2024
Copy link

github-actions bot commented Jan 17, 2024

Bug-tracker data:
Ticket title is 'launch.py: report clean error if extra yaml does not exist'
Status is 'In Progress'
Labels: 'test_infra'
https://daosio.atlassian.net/browse/DAOS-15031

@daltonbohning
Copy link
Contributor Author

@phender The benefit of this approach is that it exits as early as possible and is simple. But it will not create a job.log in the event of failure. E.g.

$ ./launch.py -e fake
...
launcher.py: error: argument -e/--extra_yaml: File not found: fake

But this is inline with other invalid arguments. E.g.

$ ./launch.py -tm not-a-float
launcher.py: error: argument -tm/--timeout_multiplier: invalid float value: 'not-a-float'

@daltonbohning daltonbohning force-pushed the dbohning/daos-15031 branch 5 times, most recently from 9ec2b94 to 488dbea Compare January 17, 2024 23:22
Test-tag: test_always_passes test_soak_smoke
Skip-unit-tests: true
Skip-fault-injection-test: true

Exit as early as possible if extra yaml is not a file.
Also convert servers and clients to a NodeSet early.
Also parse --logs_threshold early

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13624/7/execution/node/973/log

@daltonbohning
Copy link
Contributor Author

soak_smoke failure is
https://daosio.atlassian.net/browse/DAOS-14548

Test-tag: pr,vm test_soak_smoke
Skip-unit-tests: true
Skip-fault-injection-test: true

Based on find -size
https://man7.org/linux/man-pages/man1/find.1.html

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13624/10/execution/node/974/log

@daltonbohning daltonbohning marked this pull request as ready for review January 19, 2024 22:25
@daltonbohning daltonbohning requested a review from a team as a code owner January 19, 2024 22:25
@phender phender merged commit 6875d7f into master Jan 25, 2024
29 checks passed
@phender phender deleted the dbohning/daos-15031 branch January 25, 2024 23:36
daltonbohning added a commit that referenced this pull request Jan 29, 2024
…13624)

Test-tag: pr,vm test_soak_smoke
Skip-unit-tests: true
Skip-fault-injection-test: true

Exit as early as possible if extra yaml is not a file.
Also convert servers and clients to a NodeSet early.
Also parse --logs_threshold early

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
phender pushed a commit that referenced this pull request Feb 1, 2024
…13624) (#13683)

Exit as early as possible if extra yaml is not a file.
Also convert servers and clients to a NodeSet early.
Also parse --logs_threshold early

Signed-off-by: Dalton Bohning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants