Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-14969 test: Fix setting crt_timeout for daos_test/suite.py #13623

Closed
wants to merge 3 commits into from

Conversation

phender
Copy link
Contributor

@phender phender commented Jan 17, 2024

Previous changes were prematurely landed and this fixes the intended change.

Test-repeat: 10
Test-tag: test_daos_oid_allocator test_daos_management

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Previous changes were prematurely landed and this fixes the intended
change.

Test-repeat: 10
Test-tag: test_daos_oid_allocator test_daos_management

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender phender requested a review from a team as a code owner January 17, 2024 15:52
Copy link

Bug-tracker data:
Ticket title is 'daos_test/suite.py:DaosCoreTest.test_daos_oid_allocator - test timeout'
Status is 'In Progress'
Labels: 'ci_impact,pr_test'
https://daosio.atlassian.net/browse/DAOS-14969

daltonbohning
daltonbohning previously approved these changes Jan 17, 2024
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13623/1/execution/node/1300/log

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DaosCoreTest

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13623/2/execution/node/887/log

@liw
Copy link
Contributor

liw commented Jan 21, 2024

Since we seem to have a produce fix already, should we revert the prematurely landed test changes instead?

@phender
Copy link
Contributor Author

phender commented Jan 25, 2024

Since we seem to have a produce fix already, should we revert the prematurely landed test changes instead?

Yes, revert PR is #13673. Closing this one.

@phender phender closed this Jan 25, 2024
@phender phender deleted the pahender/DAOS-14969-fix branch January 25, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants