Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-13252 tests: set svcn for multiple_failure test #13619

Merged
merged 1 commit into from
Jan 18, 2024
Merged

DAOS-13252 tests: set svcn for multiple_failure test #13619

merged 1 commit into from
Jan 18, 2024

Conversation

liuxuezhao
Copy link
Contributor

original set 1 cannot work if the killed rank happened to be the only server replica.

Test-tag: ec_multiple_failure

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@liuxuezhao liuxuezhao requested a review from a team as a code owner January 17, 2024 03:15
@github-actions GitHub Actions
Copy link

Bug-tracker data:
Ticket title is 'erasurecode/multiple_failure.py:EcodOnlineMultFail.test_ec_single_target_rank_failure - timeout after stopping rank 11'
Status is 'Reopened'
Labels: 'triaged,weekly_test'
https://daosio.atlassian.net/browse/DAOS-13252

@liuxuezhao
DAOS-13252 tests: set svcn 3 for multiple_failure test
b540e96 
original set 1 cannot work if the killed rank happened to be the
only server replica.

Test-tag: ec_multiple_failure

Required-githooks: true

Signed-off-by: Xuezhao Liu <[email protected]>
@liuxuezhao liuxuezhao changed the title DAOS-13252 tests: set svcn 3 for multiple_failure test DAOS-13252 tests: set svcn for multiple_failure test Jan 17, 2024
@liuxuezhao liuxuezhao requested review from a team and removed request for NiuYawei January 18, 2024 07:09
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 18, 2024
@phender phender merged commit 91b93c8 into master Jan 18, 2024
31 checks passed
@phender phender deleted the lxz/svcn_fix branch January 18, 2024 23:22
liuxuezhao added a commit that referenced this pull request Jan 29, 2024
@liuxuezhao
DAOS-14903 container: refine task process in pmap_refresh_cb (#13491)
890a562 
should register completion callback before task reinit, or the complete
cb possibly cannot be triggered.

and a few other backports:
6d4e549 - DAOS-14788 pool: Fix some reinit usages (#13518)
91b93c8 - DAOS-13252 tests: set svcn for multiple_failure test (#13619)
d30e842 - DAOS-14903 object: fix bug in peer status check (#13585)

Required-githooks: true

Signed-off-by: Xuezhao Liu <[email protected]>
Signed-off-by: Li Wei <[email protected]>
@liuxuezhao liuxuezhao mentioned this pull request Jan 29, 2024
Merged
18 tasks
liuxuezhao added a commit that referenced this pull request Jan 30, 2024
@liuxuezhao
DAOS-14903 container: refine task process in pmap_refresh_cb (#13491)
1d6011d 
should register completion callback before task reinit, or the complete
cb possibly cannot be triggered.

and a few other backports:
6d4e549 - DAOS-14788 pool: Fix some reinit usages (#13518)
91b93c8 - DAOS-13252 tests: set svcn for multiple_failure test (#13619)
d30e842 - DAOS-14903 object: fix bug in peer status check (#13585)

Required-githooks: true
Test-tag: pr ec_multiple_failure

Signed-off-by: Xuezhao Liu <[email protected]>
Signed-off-by: Li Wei <[email protected]>
daltonbohning pushed a commit that referenced this pull request Feb 2, 2024
@liuxuezhao
DAOS-14903 container: refine task process in pmap_refresh_cb (#13491) (…
60bbb3a 
…#13682)

should register completion callback before task reinit, or the complete
cb possibly cannot be triggered.

and a few other backports:
6d4e549 - DAOS-14788 pool: Fix some reinit usages (#13518)
91b93c8 - DAOS-13252 tests: set svcn for multiple_failure test (#13619)
d30e842 - DAOS-14903 object: fix bug in peer status check (#13585)

Signed-off-by: Xuezhao Liu <[email protected]>
Signed-off-by: Li Wei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning approved these changes

@wangdi1 wangdi1 wangdi1 approved these changes

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liuxuezhao @daltonbohning @wangdi1 @phender