Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14884 pool: set the pool server handle before update #13618

Merged
merged 4 commits into from
Jan 19, 2024
Merged

DAOS-14884 pool: set the pool server handle before update #13618

merged 4 commits into from
Jan 19, 2024

Conversation

wangdi1
Copy link
Contributor

@wangdi1 wangdi1 commented Jan 16, 2024

Set the pool server handler before IV update, to make sure IV server checking accurate on the PS leader once step up finish.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@wangdi1 wangdi1 requested review from liw and knard38 January 16, 2024 18:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2024 •
edited
Loading

Bug-tracker data:
Ticket title is 'create_no_space_loop failed due to dmg failure (dmg: either --size or --scm-size must be set)'
Status is 'In Review'
Labels: 'ci_impact,pr_test,request_for_2.6,triaged'
https://daosio.atlassian.net/browse/DAOS-14884

tanabarr
tanabarr previously approved these changes Jan 16, 2024
View reviewed changes
@tanabarr
Copy link
Contributor

tanabarr commented Jan 16, 2024 •
edited
Loading

@phender @daltonbohning Will this CI run touch any of the affected tests with no "Features" or "Test-tag" pragmas? I vote for force landing and then trigger a master daily run.

@daltonbohning
Copy link
Contributor

@phender @daltonbohning Will this CI run touch any of the affected tests with no "Features" or "Test-tag" pragmas? I vote for force landing and then trigger a master daily run.

"any" of the affected tests, yes. There are basic pool tests in the pr set. But daily or weekly tests could still be affected. If they are expected to be affected, then we should run them here.

I vote for force landing and then trigger a master daily run.

We would already get results from the next daily run, so no need to trigger another. But again, if we expect some areas to be affected then we should run those tests now. Otherwise we introduce more regressions in CI that cause more churn and more people to look through known failures, and ultimately closes landing again.

@wangdi1
DAOS-14884 pool: set the pool server handle before update
9e8be9c 
Set the pool server handler before IV update, to make sure
IV server checking accurate on the PS leader once step up finish.

Required-githooks: true

Signed-off-by: Di Wang <[email protected]>
tanabarr
tanabarr previously approved these changes Jan 16, 2024
View reviewed changes
@tanabarr
Copy link
Contributor

@phender @daltonbohning Will this CI run touch any of the affected tests with no "Features" or "Test-tag" pragmas? I vote for force landing and then trigger a master daily run.

"any" of the affected tests, yes. There are basic pool tests in the pr set. But daily or weekly tests could still be affected. If they are expected to be affected, then we should run them here.

I vote for force landing and then trigger a master daily run.

We would already get results from the next daily run, so no need to trigger another. But again, if we expect some areas to be affected then we should run those tests now. Otherwise we introduce more regressions in CI that cause more churn and more people to look through known failures, and ultimately closes landing again.

PR is not being run with any pragmas.

@daltonbohning
Copy link
Contributor

PR is not being run with any pragmas.

Right. Which means only the default set of pr tests are ran

liw
liw previously approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@liw liw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay.

src/pool/srv_pool.c
* container server handle will not be copied here, otherwise
* ds_pool_iv_refresh_hdl will not open the server handle container.
*/
uuid_copy(svc->ps_pool->sp_srv_pool_hdl, pool_hdl_uuid);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, there seems to be a data race on sp_srv_pool_hdl if a non-system xstream calls ds_pool_iv_srv_hdl_fetch_non_sys to read sp_srv_pool_hdl when the pool_iv code or this new uuid_copy code updates sp_srv_pool_hdl.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sp_srv_pool_hdl and sp_srv_cont_hdl will only be accessed by system xstream. Hmm, ds_pool_iv_srv_hdl_fetch_non_sys is obsolete, should be removed. let me remove it if the PR needs to refresh.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that's good.

src/pool/srv_pool.c Outdated
@@ -1810,6 +1810,11 @@ pool_svc_step_up_cb(struct ds_rsvc *rsvc)
} else {
uuid_generate(pool_hdl_uuid);
uuid_generate(cont_hdl_uuid);
/* Only copy server handle to make is_from_srv() check correctly, and
* container server handle will not be copied here, otherwise
* ds_pool_iv_refresh_hdl will not open the server handle container.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Nit] Does the first line mean "pool server handle" instead of "server handle"? On the last line, what is "the server handle container"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, pool server handle means pool handle for server to server communication. Sorry, it should be container server handle.

@wangdi1
DAOS-14884 pool: remove is_from_srv check
20018c0 
Remove obsolete is_from_srv check for space query, and remove
obsolete functions.

Required-githooks: true

Signed-off-by: Di Wang <[email protected]>
@wangdi1
Merge branch 'master' into wangdi/daos_14884
9a8da27
@wangdi1 wangdi1 dismissed stale reviews from liw and tanabarr via 9a8da27 January 17, 2024 06:45
@wangdi1 wangdi1 requested review from liw and tanabarr January 17, 2024 06:46
@wangdi1
Copy link
Contributor Author

wangdi1 commented Jan 17, 2024

Updated the patch to resolve Li Wei's comments

knard38
knard38 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Locally tested with my reproducer.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13618/3/execution/node/1434/log

@wangdi1
Copy link
Contributor Author

wangdi1 commented Jan 18, 2024

failure due to DAOS-14969

@wangdi1 wangdi1 requested a review from a team January 18, 2024 01:29
@phender
Copy link
Contributor

phender commented Jan 18, 2024

To verify the fix for the failing pool/create.py:PoolCreateTests.test_create_no_space_loop test this PR should be running with the Features: pool commit pragma.

@wangdi1
Merge branch 'master' into wangdi/daos_14884
999f668 
Features: pool

Required-githooks: true
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13618/5/execution/node/1429/log

@mchaarawi mchaarawi merged commit be4402b into master Jan 19, 2024
28 of 29 checks passed
@mchaarawi mchaarawi deleted the wangdi/daos_14884 branch January 19, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liw liw liw approved these changes

@tanabarr tanabarr tanabarr approved these changes

@jolivier23 jolivier23 jolivier23 approved these changes

@knard38 knard38 knard38 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@wangdi1 @tanabarr @daltonbohning @daosbuild1 @phender @liw @jolivier23 @knard38 @mchaarawi