DAOS-12710 build: Add unit testing that header can be included. #13617
Conversation
Add a unit test to verify all installed headers can be included standalone. Remove scons check for cart and gurt headers for the same. Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>
ashleypittman
force-pushed
the
amd/header-check
branch
from
2eb2a3d to
9af62e0
Compare
|
Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13617/2/execution/node/124/log |
|
Bug-tracker data: |
|
Test stage Unit Test on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13617/2/execution/node/733/log |
Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>
Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>
|
Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13617/3/testReport/ |
|
Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13617/3/testReport/ |
Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>
|
Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13617/4/testReport/ |
|
Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13617/4/testReport/ |
Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>
|
Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13617/5/testReport/ |
|
Test stage Unit Test with memcheck on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13617/5/testReport/ |
| with open(".build_vars.json", "r") as ofh: | ||
| bc = json.load(ofh) | ||
|
|
||
| include_dir = f"{bc['PREFIX']}/include" |
There was a problem hiding this comment.
| include_dir = f"{bc['PREFIX']}/include" | |
| include_dir = os.path.join(bc['PREFIX'], "include") |
| include_dir = f"{bc['PREFIX']}/include" | ||
|
|
||
| check_dir(include_dir, None) | ||
| os.unlink("a.out") |
There was a problem hiding this comment.
Nit. I think it's better to move this unlink to the helper function which generates it
There was a problem hiding this comment.
Each compile test will create/overwrite it, removing it on each iteration would be extra work although possibly clearer as you say.
| """Check the whole tree""" | ||
|
|
||
| with open(".build_vars.json", "r") as ofh: | ||
| bc = json.load(ofh) |
There was a problem hiding this comment.
What does bc stand for? Could we use something more self-documenting?
There was a problem hiding this comment.
build_config? I'll change it to bv to match the filename.
| if not os.path.isfile(os.path.join(h_dir, entry)): | ||
| check_dir(include_dir, entry) |
There was a problem hiding this comment.
FYI
| if not os.path.isfile(os.path.join(h_dir, entry)): | |
| check_dir(include_dir, entry) | |
| if os.path.isdir(os.path.join(h_dir, entry)): | |
| check_dir(include_dir, entry) |
| h_dir = os.path.join(include_dir, sub_dir) | ||
| for entry in sorted(os.listdir(h_dir)): | ||
| if not os.path.isfile(os.path.join(h_dir, entry)): | ||
| check_dir(include_dir, entry) |
There was a problem hiding this comment.
This only works recursively once, right? But that's okay because our includes aren't deep
|
Pr has been merged into #13613 but I'll push feedback there. |
Add a unit test to verify all installed headers can be included
standalone.
Remove scons check for cart and gurt headers for the same.
Required-githooks: true
Signed-off-by: Ashley Pittman [email protected]