Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-13584 tests: limit pool query test time (#12451) #13578

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

kccain
Copy link
Contributor

@kccain kccain commented Jan 8, 2024

Cherry-pick master commit a81c0b2 to release/2.4 branch

Test-tag: test_daos_md_replication
Test-repeat: 20
Skip-unit-tests: true
Skip-fault-injection-test: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Cherry-pick master commit a81c0b2 to release/2.4 branch

Test-tag: test_daos_md_replication
Test-repeat: 20
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Wang Shilong <[email protected]>
Signed-off-by: Kenneth Cain <[email protected]>
Copy link

github-actions bot commented Jan 8, 2024

Bug-tracker data:
Ticket title is 'MDR1: MD replication tests hung during pool query'
Status is 'In Review'
Labels: 'md_on_ssd,request_for_2.4.2'
https://daosio.atlassian.net/browse/DAOS-13584

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@kccain kccain added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 9, 2024
@kccain kccain marked this pull request as ready for review January 9, 2024 12:26
@kccain
Copy link
Contributor Author

kccain commented Jan 9, 2024

Jenkins build 1 functional testing passed 10 repeat loops, all finishing in a window of about 90-95 seconds of run time. Ready for review. Ran only with the specific test tag associated with daos_test -R (md_replication) where the code change is exclusively made.

@kccain kccain added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jan 9, 2024
@kccain
Copy link
Contributor Author

kccain commented Jan 9, 2024

added the request_for_2.4.2 label to the associated JIRA ticket https://daosio.atlassian.net/browse/DAOS-13584

@kccain
Copy link
Contributor Author

kccain commented Jan 10, 2024

Thanks for the reviews @daltonbohning and @wangshilong . Waiting for merge approval in ticket https://daosio.atlassian.net/browse/DAOS-13584 before requesting gatekeeper review/landing.

@kccain kccain requested a review from a team January 20, 2024 02:51
@kccain
Copy link
Contributor Author

kccain commented Jan 20, 2024

still waiting for merge approval in https://daosio.atlassian.net/browse/DAOS-13584 but I think since release/2.4 branch is open for landings, I'll add @daos-stack/daos-gatekeeper to the review now.

@mchaarawi
Copy link
Contributor

still waiting for merge approval in https://daosio.atlassian.net/browse/DAOS-13584 but I think since release/2.4 branch is open for landings, I'll add @daos-stack/daos-gatekeeper to the review now.

please add gatekeeper after merge approval is granted. otherwise this will be ignored by gatekeepers and lost in the backlog of prs to looks at.

@mchaarawi mchaarawi removed the request for review from a team January 20, 2024 16:07
@wangshilong wangshilong requested a review from a team January 22, 2024 01:50
@mchaarawi mchaarawi removed the request for review from a team January 22, 2024 14:19
@mchaarawi mchaarawi merged commit 8b5ffa6 into release/2.4 Jan 22, 2024
21 of 22 checks passed
@mchaarawi mchaarawi deleted the kccain/daos_13584_rel2p4 branch January 22, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

5 participants