Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14793 control: Fail if VMD has no backing storage (#13503) #13546

Merged
merged 2 commits into from
Jan 24, 2024
Merged

DAOS-14793 control: Fail if VMD has no backing storage (#13503) #13546

merged 2 commits into from
Jan 24, 2024

Conversation

tanabarr
Copy link
Contributor

@tanabarr tanabarr commented Dec 29, 2023 •
edited
Loading

Report the specific case where VMD address has no backing devices. A
bdev scan of PCI address specified in server config file bdev_list
should report an error indicating if any of the addresses are for a
VMD which has no backing storage (backing NVMe SSDs).

Features: control
Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@tanabarr
DAOS-14793 control: Fail if VMD has no backing storage (#13503)
ebdbc8e 
Report the specific case where VMD address has no backing devices. A
bdev scan of PCI address specified in server config file bdev_list
should report an error indicating if any of the addresses are for a
VMD which has no backing storage (backing NVMe SSDs).

Features: control
Required-githooks: true

Signed-off-by: Tom Nabarro <[email protected]>
@tanabarr tanabarr requested a review from a team as a code owner December 29, 2023 13:08
@tanabarr tanabarr requested review from mjmac and kjacque and removed request for a team December 29, 2023 13:08
@github-actions GitHub Actions
Copy link

Bug-tracker data:
Ticket title is 'Report when VMD address has no backing devices'
Status is 'Awaiting backport'
Labels: 'VMD,request_for_2.4.2'
https://daosio.atlassian.net/browse/DAOS-14793

daosbuild1
daosbuild1 reviewed Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13546/1/testReport/

@tanabarr
Copy link
Contributor Author

tanabarr commented Dec 30, 2023 •
edited
Loading

CI failures with Features: control all due to DAOS-14718 (#13441 is passing and waiting for reviews before being able to backport to 2.4)

@tanabarr tanabarr requested a review from knard38 January 2, 2024 10:56
@tanabarr tanabarr self-assigned this Jan 2, 2024
@tanabarr tanabarr added control-plane work on the management infrastructure of the DAOS Control Plane release-2.4 PR is eventually targeted for 2.4 forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. labels Jan 2, 2024
@knard38
Copy link
Contributor

knard38 commented Jan 2, 2024

CI failures seems to not be related to this PR as they are also happening in the PR https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-13490/5/testReport/ from @kjacque .

knard38
knard38 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the release-2.4 PR is eventually targeted for 2.4 label Jan 3, 2024
@tanabarr tanabarr requested a review from a team January 3, 2024 09:49
@daltonbohning
Copy link
Contributor

Still awaiting merge approval for 2.4.2

@tanabarr
Merge remote-tracking branch 'origin/release/2.4' into tanabarr/contr…
e579578 
…ol-vmd-missing-backing-error-rel2_4

Features: control
Signed-off-by: Tom Nabarro <[email protected]>
@tanabarr tanabarr added clean-cherry-pick Cherry-pick from another branch that did not require additional edits and removed forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. labels Jan 22, 2024
daosbuild1
daosbuild1 reviewed Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@tanabarr tanabarr added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 23, 2024
@tanabarr
Copy link
Contributor Author

CI run nr. 2 (https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-13546/2/tests/) failed with the following known issue:

@mchaarawi
Copy link
Contributor

CI run nr. 2 (https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-13546/2/tests/) failed with the following known issue:

DAOS-14793 has not gone through merge approvals yet. please request gatekeeper when it's approved to merge.

@tanabarr tanabarr removed the request for review from a team January 23, 2024 16:29
@tanabarr
Copy link
Contributor Author

CI run nr. 2 (https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-13546/2/tests/) failed with the following known issue:

DAOS-14793 has not gone through merge approvals yet. please request gatekeeper when it's approved to merge.

yes apologies I removed the gatekeeper a couple of minutes ago when I realised

@tanabarr tanabarr requested a review from a team January 24, 2024 18:37
@tanabarr
Copy link
Contributor Author

merge approval has been given

@mchaarawi mchaarawi merged commit 1deddcd into release/2.4 Jan 24, 2024
37 checks passed
@mchaarawi mchaarawi deleted the tanabarr/control-vmd-missing-backing-error-rel2_4 branch January 24, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@kjacque kjacque kjacque approved these changes

@knard38 knard38 knard38 approved these changes

@mjmac mjmac Awaiting requested review from mjmac mjmac is a code owner automatically assigned from daos-stack/go-watchers

Assignees

@tanabarr tanabarr

Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits control-plane work on the management infrastructure of the DAOS Control Plane forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tanabarr @daosbuild1 @knard38 @daltonbohning @mchaarawi @kjacque