Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-12425 control: Add opt to auto-format on server start-up (#13074) #13475

Merged
merged 1 commit into from
Jan 25, 2024
Merged

DAOS-12425 control: Add opt to auto-format on server start-up (#13074) #13475

merged 1 commit into from
Jan 25, 2024

Conversation

daltonbohning
Copy link
Contributor

Features: control

Add daos_server start --auto-format option to enable engines to start without having to trigger a storage format with an externally executed dmg storage format command. If the flag is detected the server will call the format API during its start-up routine and if the server config file used is valid the engines will be started after format completes.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Dec 11, 2023
@daltonbohning daltonbohning self-assigned this Dec 11, 2023
daosbuild1
daosbuild1 reviewed Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@github-actions GitHub Actions
Copy link

Bug-tracker data:
Ticket title is 'Add option to format storage and start engines on server start'
Status is 'Awaiting backport'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-12425

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Dec 11, 2023
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13475/1/execution/node/1149/log

@tanabarr @daltonbohning
DAOS-12425 control: Add opt to auto-format on server start-up (#13074)
843984a 
Features: control

Add daos_server start --auto-format option to enable engines to start
without having to trigger a storage format with an externally executed
dmg storage format command. If the flag is detected the server will call
the format API during its start-up routine and if the server config
file used is valid the engines will be started after format completes.

Required-githooks: true

Signed-off-by: Tom Nabarro <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning force-pushed the dbohning/daos-12425-2.4 branch from 9edeecb to 843984a Compare January 18, 2024 20:32
daosbuild1
daosbuild1 reviewed Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13475/2/execution/node/1122/log

daosbuild1
daosbuild1 reviewed Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13475/3/execution/node/1122/log

daosbuild1
daosbuild1 reviewed Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daltonbohning daltonbohning marked this pull request as ready for review January 22, 2024 16:24
@daltonbohning daltonbohning requested a review from a team as a code owner January 22, 2024 16:24
@daltonbohning daltonbohning requested review from mjmac, kjacque and tanabarr and removed request for a team January 22, 2024 16:24
@daltonbohning daltonbohning requested a review from a team January 22, 2024 17:27
@daltonbohning
Copy link
Contributor Author

Github claims some checks aren't complete, but they obviously are here:
https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-13475/4/pipeline

@phender phender merged commit c2a4178 into release/2.4 Jan 25, 2024
26 checks passed
@phender phender deleted the dbohning/daos-12425-2.4 branch January 25, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@mjmac mjmac mjmac approved these changes

@tanabarr tanabarr tanabarr approved these changes

@kjacque kjacque kjacque approved these changes

Assignees

@daltonbohning daltonbohning

Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits priority Ticket has high priority (automatically managed)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@daltonbohning @daosbuild1 @mjmac @tanabarr @kjacque @phender