Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aurora 2.4 test branch #13457

Closed
wants to merge 5 commits into from
Closed

Aurora 2.4 test branch #13457

wants to merge 5 commits into from

Conversation

daltonbohning
Copy link
Contributor

Skip-test: true
Skip-unit-test: true
Skip-unit-tests: true

  • Replace --bind-to and --map-by with generic args to support flexible options.
  • Update mpirun np AND ppn to be compatible with more implementations

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning
DAOS-14650 test: replace mpirun bind-to and map-by with args (#13392)
9be1a2a 
Skip-test: true
Skip-unit-test: true
Skip-unit-tests: true

- Replace --bind-to and --map-by with generic args to support flexible
  options.
- Update mpirun np AND ppn to be compatible with more implementations

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning added don't land do-not-delete-branch Branch is required for CI testing labels Dec 7, 2023
@daltonbohning daltonbohning self-assigned this Dec 7, 2023
daosbuild1
daosbuild1 reviewed Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Bug-tracker data:
Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/Aurora

@daltonbohning
DAOS-14650 test: replace mpirun bind-to and map-by with args (#13392)
ebf7ed0 
Skip-test: true
Skip-unit-test: true
Skip-unit-tests: true

- Replace --bind-to and --map-by with generic args to support flexible
  options.
- Update mpirun np AND ppn to be compatible with more implementations

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
daosbuild1
daosbuild1 reviewed Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@mjean308
Merge branch 'aurora/2.4' of https://github.com/daos-stack/daos into …
6172d80 
…aurora/2.4

Required-githooks: true

Signed-off-by: Maureen Jean <[email protected]>
daosbuild1
daosbuild1 reviewed Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daosbuild1
daosbuild1 reviewed Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13457/4/execution/node/1119/log

@daltonbohning daltonbohning deleted the aurora/2.4 branch May 29, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

Assignees

@daltonbohning daltonbohning

Labels
do-not-delete-branch Branch is required for CI testing don't land
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daltonbohning @daosbuild1 @mjean308