Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14650 test: replace mpirun bind-to and map-by with args (#13392) #13433

Merged
merged 1 commit into from
Jan 25, 2024
Merged

DAOS-14650 test: replace mpirun bind-to and map-by with args (#13392) #13433

merged 1 commit into from
Jan 25, 2024

Conversation

daltonbohning
Copy link
Contributor

Test-tag: pr IorEasy,-manual IorHard,-manual MdtestEasy,-manual MdtestHard,-manual TelemetryPoolSpaceMetrics AgentFailure TargetFailure datamover ior mdtest
Skip-unit-tests: true
Skip-fault-injection-test: true

  • Replace --bind-to and --map-by with generic args to support flexible options.
  • Update mpirun np AND ppn to be compatible with more implementations

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning added the unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. label Dec 4, 2023
@daltonbohning daltonbohning self-assigned this Dec 4, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

Bug-tracker data:
Ticket title is 'ftest: support generic extra mpi args'
Status is 'Awaiting backport'
Labels: 'tds,test_infra'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-14650

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Dec 4, 2023
daosbuild1
daosbuild1 reviewed Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13433/1/execution/node/865/log

@daltonbohning daltonbohning force-pushed the dbohning/daos-14650-2.4 branch from ced53d5 to 6b6b1e1 Compare December 6, 2023 17:36
daosbuild1
daosbuild1 reviewed Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13433/2/execution/node/872/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13433/2/testReport/

@daltonbohning daltonbohning force-pushed the dbohning/daos-14650-2.4 branch from 6b6b1e1 to d95631f Compare January 2, 2024 19:59
daosbuild1
daosbuild1 reviewed Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13433/3/execution/node/988/log

@daltonbohning
DAOS-14650 test: replace mpirun bind-to and map-by with args (#13392)
f5e80f7 
Test-tag: pr IorEasy,-manual IorHard,-manual MdtestEasy,-manual MdtestHard,-manual TelemetryPoolSpaceMetrics AgentFailure TargetFailure datamover ior mdtest
Skip-unit-tests: true
Skip-fault-injection-test: true

- Replace --bind-to and --map-by with generic args to support flexible
  options.
- Update mpirun np AND ppn to be compatible with more implementations

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning force-pushed the dbohning/daos-14650-2.4 branch from d95631f to f5e80f7 Compare January 18, 2024 20:31
daosbuild1
daosbuild1 reviewed Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13433/4/testReport/

@daltonbohning daltonbohning marked this pull request as ready for review January 22, 2024 16:19
@daltonbohning daltonbohning requested a review from a team as a code owner January 22, 2024 16:19
@daltonbohning
Copy link
Contributor Author

Failure in https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-13433/4/tests
is because this needs to be backported: https://daosio.atlassian.net/browse/DAOS-14654

@daltonbohning daltonbohning requested a review from a team January 23, 2024 17:00
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 23, 2024
@phender phender merged commit bd85dc6 into release/2.4 Jan 25, 2024
19 of 20 checks passed
@phender phender deleted the dbohning/daos-14650-2.4 branch January 25, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@shimizukko shimizukko shimizukko approved these changes

@rpadma2 rpadma2 rpadma2 approved these changes

@saurabhtandan saurabhtandan Awaiting requested review from saurabhtandan

@phender phender Awaiting requested review from phender

Assignees

@daltonbohning daltonbohning

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed) unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daltonbohning @daosbuild1 @shimizukko @rpadma2 @phender