DAOS-13936 support: Collect the specific logs and Time range log for support #13325

ravalsam · 2023-11-10T03:07:35Z

Adding feature to collect specific log only, Admin/Control/Engine.
Adding option to collect the engine log based on date and time range.
Fix the control log to add the date to be aligned with server engine/admin logs.

Test-tag: pr support

Required-githooks: true

Before requesting gatekeeper:

Two review approvals and any prior change requests have been resolved.
Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
Commit messages follows the guidelines outlined here.
Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

…support purpose. - Adding feature to collect specific log only, Admin/Control/Engine. - Adding option to collect the engine log based on date and time range. - Fix the control log to add the date to be aligned with server engine/admin logs. Test-tag: pr support Required-githooks: true Signed-off-by: Samir Raval <[email protected]>

github-actions · 2023-11-10T03:07:52Z

Bug-tracker data:
Ticket title is 'Collect the specific logs and Time range log for support'
Status is 'In Review'
Errors are Unknown component
https://daosio.atlassian.net/browse/DAOS-13936

daosbuild1

LGTM. No errors found by checkpatch.

Test-tag: pr support Required-githooks: true

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-11-10T03:39:47Z

Test stage Unit Test on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13325/2/testReport/

Test-tag: pr support Required-githooks: true Signed-off-by: Samir Raval <[email protected]>

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-11-14T17:11:29Z

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13325/3/execution/node/1412/log

ravalsam · 2023-11-14T17:22:28Z

One test failure is not related to this PR and existing defect is open for failure https://daosio.atlassian.net/browse/DAOS-14585.

kjacque · 2023-11-17T01:05:26Z

src/control/cmd/daos_server/support.go

+		LogCollection[support.CopyServerConfigEnum] = []string{""}
+		LogCollection[support.CollectSystemCmdEnum] = support.SystemCmd
+		LogCollection[support.CollectDaosServerCmdEnum] = support.DaosServerCmd
+		LogCollection[support.CollectServerLogEnum] = support.ServerLog


Could this be shared too? I wonder if it would be better to pass the cmd.LogType as a parameter to cmd.LogTypeValidate().

You mean populate this in function cmd.LogTypeValidate()?

Yes, exactly.

src/control/cmd/daos_server/support.go

src/control/lib/control/support.go

src/control/lib/support/log_test.go

src/control/lib/support/log.go

tanabarr

Looks like Kris has done a thorough review which I agree with and I've just added a couple of extra comments

src/control/lib/support/log.go

tanabarr

Apologies I didn't mean to approve it yet.

Test-tag: pr support Required-githooks: true Signed-off-by: Samir Raval <[email protected]>

daosbuild1

LGTM. No errors found by checkpatch.

Test-tag: pr support

daosbuild1

LGTM. No errors found by checkpatch.

daosbuild1 · 2023-12-10T21:40:06Z

Test stage Functional Hardware Medium Verbs Provider completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13325/5/testReport/

ravalsam · 2023-12-11T03:19:32Z

Single test failure is not related to this PR and it's existing open issue https://daosio.atlassian.net/browse/DAOS-14353

daosbuild1 · 2024-02-07T02:34:13Z

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13325/19/execution/node/1510/log

daosbuild1 · 2024-02-07T15:21:15Z

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13325/20/execution/node/420/log

Test-tag: pr support

daosbuild1 · 2024-02-08T04:23:24Z

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13325/21/execution/node/1460/log

ravalsam · 2024-02-08T17:00:51Z

There are few test failure but it's not related to this PR and created new ticket DAOS-15165

daltonbohning

ftest code changes LGTM

mjmac · 2024-02-27T14:24:41Z

@ravalsam: Code changes look fine to me, but I can't force land. You'll either need to request a forced landing from other gatekeepers (by adding the forced-landing label), or merge master and re-run to try for clean test results.

mchaarawi · 2024-02-27T14:47:49Z

please rerun with
Features: control
commit pragma

Features: control

ravalsam · 2024-02-27T16:41:29Z

@ravalsam: Code changes look fine to me, but I can't force land. You'll either need to request a forced landing from other gatekeepers (by adding the forced-landing label), or merge master and re-run to try for clean test results.

Thank you for the review. Merged the master and will wait for the test results.

github-actions · 2024-02-27T16:42:55Z

Ticket title is 'Collect the specific logs and Time range log for support'
Status is 'In Review'
Labels: 'usability'
Errors are Unknown component
https://daosio.atlassian.net/browse/DAOS-13936

daosbuild1 · 2024-02-27T20:41:28Z

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13325/22/execution/node/1173/log

ravalsam · 2024-02-28T15:44:55Z

Single test failed because of other issue DAOS-15283 and not related to this PR.

Although this port copies the code from master to 2.4, there are issues related to permissions making it non-functional. This is a partial cherry-pick of the following PR's on master: DAOS-10625 control: Create the tool to collect the logs/config for support purpose (#11094) DAOS-13759 control: Update support collect-log tool. (#12906) DAOS-13763 control: Fix daos_metrics collection for support collect-log. (#12555) DAOS-13936 support: Collect the specific logs and Time range log for support (#13325) Change-Id: I168c14e177a5003c4e315595b1bf154e84cef473

Although this port copies the code from master to 2.4, there are issues related to permissions making it non-functional. This is a partial cherry-pick of the following PR's on master: DAOS-10625 control: Create the tool to collect the logs/config for support purpose (#11094) DAOS-13759 control: Update support collect-log tool. (#12906) DAOS-13763 control: Fix daos_metrics collection for support collect-log. (#12555) DAOS-13936 support: Collect the specific logs and Time range log for support (#13325) Signed-off-by: Chris Davis <[email protected]>

ravalsam requested review from a team as code owners November 10, 2023 03:07

ravalsam requested review from mjmac and tanabarr and removed request for a team November 10, 2023 03:07

daosbuild1 reviewed Nov 10, 2023

View reviewed changes

Merge branch 'master' into samirrav/support/DAOS-13936

6c891fb

Test-tag: pr support Required-githooks: true

daosbuild1 reviewed Nov 10, 2023

View reviewed changes

Fix unit test code.

33c8916

Test-tag: pr support Required-githooks: true Signed-off-by: Samir Raval <[email protected]>

ravalsam changed the title ~~DAOS-13936 support: Collect the specific logs and Time range log for support purpose.~~ DAOS-13936 support: Collect the specific logs and Time range log for support Nov 13, 2023

daosbuild1 reviewed Nov 13, 2023

View reviewed changes

ravalsam requested a review from kjacque November 14, 2023 17:31

kjacque reviewed Nov 17, 2023

View reviewed changes

tanabarr previously approved these changes Nov 23, 2023

View reviewed changes

src/control/lib/support/log.go Outdated Show resolved Hide resolved

src/control/lib/support/log.go Outdated Show resolved Hide resolved

tanabarr self-requested a review November 23, 2023 11:51

tanabarr reviewed Nov 23, 2023

View reviewed changes

tanabarr self-requested a review November 23, 2023 11:53

Code updated based on review comments.

93d576f

Test-tag: pr support Required-githooks: true Signed-off-by: Samir Raval <[email protected]>

ravalsam dismissed tanabarr’s stale review via 93d576f December 8, 2023 07:05

daosbuild1 reviewed Dec 8, 2023

View reviewed changes

Merge branch 'master' into samirrav/support/DAOS-13936

ca5cc5c

Test-tag: pr support

daosbuild1 reviewed Dec 8, 2023

View reviewed changes

ravalsam requested a review from kjacque December 12, 2023 10:19

ravalsam dismissed stale reviews from kjacque and tanabarr via b1a124d February 6, 2024 16:36

ravalsam requested review from a team as code owners February 6, 2024 16:36

Merge branch 'master' into samirrav/support/DAOS-13936

ee9d6ea

Test-tag: pr support

ravalsam requested review from tanabarr and kjacque February 8, 2024 17:01

daltonbohning reviewed Feb 8, 2024

View reviewed changes

tanabarr approved these changes Feb 8, 2024

View reviewed changes

kjacque approved these changes Feb 8, 2024

View reviewed changes

ravalsam requested a review from a team February 8, 2024 23:43

mchaarawi removed the request for review from a team February 27, 2024 14:48

Merge branch 'master' into samirrav/support/DAOS-13936

5eca28b

Features: control

ravalsam added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Feb 28, 2024

mchaarawi merged commit 59b2f55 into master Feb 28, 2024
48 of 50 checks passed

mchaarawi deleted the samirrav/support/DAOS-13936 branch February 28, 2024 15:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DAOS-13936 support: Collect the specific logs and Time range log for support #13325

DAOS-13936 support: Collect the specific logs and Time range log for support #13325

ravalsam commented Nov 10, 2023

github-actions bot commented Nov 10, 2023 •

edited

Loading

daosbuild1 left a comment

daosbuild1 left a comment

daosbuild1 commented Nov 10, 2023

daosbuild1 left a comment

daosbuild1 commented Nov 14, 2023

ravalsam commented Nov 14, 2023

kjacque Nov 17, 2023

ravalsam Nov 17, 2023

kjacque Nov 18, 2023

tanabarr left a comment

tanabarr left a comment

daosbuild1 left a comment

daosbuild1 left a comment

daosbuild1 commented Dec 10, 2023

ravalsam commented Dec 11, 2023

daosbuild1 commented Feb 7, 2024

daosbuild1 commented Feb 7, 2024

daosbuild1 commented Feb 8, 2024

ravalsam commented Feb 8, 2024

daltonbohning left a comment

mjmac commented Feb 27, 2024

mchaarawi commented Feb 27, 2024

ravalsam commented Feb 27, 2024

github-actions bot commented Feb 27, 2024

daosbuild1 commented Feb 27, 2024

ravalsam commented Feb 28, 2024

DAOS-13936 support: Collect the specific logs and Time range log for support #13325

DAOS-13936 support: Collect the specific logs and Time range log for support #13325

Conversation

ravalsam commented Nov 10, 2023

Before requesting gatekeeper:

Gatekeeper:

github-actions bot commented Nov 10, 2023 • edited Loading

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Nov 10, 2023

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Nov 14, 2023

ravalsam commented Nov 14, 2023

kjacque Nov 17, 2023

Choose a reason for hiding this comment

ravalsam Nov 17, 2023

Choose a reason for hiding this comment

kjacque Nov 18, 2023

Choose a reason for hiding this comment

tanabarr left a comment

Choose a reason for hiding this comment

tanabarr left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 left a comment

Choose a reason for hiding this comment

daosbuild1 commented Dec 10, 2023

ravalsam commented Dec 11, 2023

daosbuild1 commented Feb 7, 2024

daosbuild1 commented Feb 7, 2024

daosbuild1 commented Feb 8, 2024

ravalsam commented Feb 8, 2024

daltonbohning left a comment

Choose a reason for hiding this comment

mjmac commented Feb 27, 2024

mchaarawi commented Feb 27, 2024

ravalsam commented Feb 27, 2024

github-actions bot commented Feb 27, 2024

daosbuild1 commented Feb 27, 2024

ravalsam commented Feb 28, 2024

github-actions bot commented Nov 10, 2023 •

edited

Loading