DAOS-14073 dfuse: Move writeback caching from kernel to dfuse. #12729
Conversation
Test-tag: dfuse Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>
|
Bug-tracker data: |
|
Test stage Functional on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-12729/1/testReport/ |
Required-githooks: true
|
Test stage Functional on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-12729/2/testReport/ |
Required-githooks: true
|
Test stage Functional on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-12729/3/testReport/ |
Required-githooks: true
Test-tag: test_dfuse_daos_build_wb Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>
Required-githooks: true Test-tag: test_dfuse_daos_build_wb Skip-func-hw-test: true Skip-func-test: true Quick-Functional: true Test-tag: dfuse
|
Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12729/5/execution/node/190/log |
Required-githooks: true Test-tag: test_dfuse_daos_build_wb Signed-off-by: Ashley Pittman <[email protected]>
Required-githooks: true
Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>
Required-githooks: true
Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>
Test-tag: dfuse
Required-githooks: true
Test-tag: dfuse Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>
| @@ -138,6 +138,8 @@ dfuse_cb_release(fuse_req_t req, fuse_ino_t ino, struct fuse_file_info *fi) | |||
|
|
|||
| DFUSE_TRA_DEBUG(oh, "Closing %d", oh->doh_caching); | |||
|
|
|||
| DFUSE_IE_WFLUSH(oh->doh_ie); | |||
There was a problem hiding this comment.
This is in open.c but actually the function is release which maps to close(), this line is what causes flush-on-close which we do want to keep, and won't affect the performance of open at all.
Features: dfuse Required-githooks: true Signed-off-by: Ashley Pittman <[email protected]>
|
Ticket title is 'Move write-back cache feature into dfuse.' |
Required-githooks: true
|
Test stage Build RPM on EL 9 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12729/30/execution/node/314/log |
|
Test stage Build RPM on EL 8 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12729/30/execution/node/364/log |
|
Test stage Build RPM on Leap 15.5 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12729/30/execution/node/367/log |
Features: dfuse Required-githooks: true
|
Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12729/31/execution/node/1173/log |
ashleypittman
requested review from
daltonbohning,
johannlombardi and
jolivier23
and removed request for
jolivier23
|
Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12729/33/execution/node/1540/log |
|
Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12729/34/execution/node/424/log |
Features: dfuse
|
Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-12729/35/testReport/ |
|
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12729/36/execution/node/1405/log |
|
Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12729/36/execution/node/1501/log |
|
@daos-stack/daos-gatekeeper can this be landed now? The most recent run with test-tags was https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12729/35/ and that passed with only DAOS-15616 failing. |
Have dfuse implement write-back caching rather than relying on the kernel.
Having the kernel do this means that the kernel assumes that it is the
single point of truth for both file size and mtime so it will disregard any
updates from dfuse which makes working across multiple clients very
difficult.
This change removes the kernel flag allowing it to perform writeback caching
but rather if enabled at the dfuse level then dfuse will acknowledge writes
to the kernel before daos/dfs has acknowledged them on the backend. This
gives better performance in the (default) writeback case as it means the kernel
does not make a setattr call to update the mtime after every write and it
re-instates same semantics where the kernel will handle updates from other
clients correctly.
The kernel writeback cache would also perform write coalescing of smaller writes
into larger ones, and dfuse no longer gets the benefit of that, this is something we
need to add back into dfuse as part of future work.
Signed-off-by: Ashley Pittman [email protected]