Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-11406 rdb: Use VOS local TXs #12330

Merged
merged 3 commits into from
Apr 16, 2024
Merged

DAOS-11406 rdb: Use VOS local TXs #12330

merged 3 commits into from
Apr 16, 2024

Conversation

liw
Copy link
Contributor

@liw liw commented Jun 9, 2023 •
edited
Loading

Every RDB (update) TX invokes multiple VOS writes, each of which
performs a WAL commit. This patch reduces those WAL commits to one per
RDB TX by utilizing the new VOS local TXs to group all VOS writes of one
RDB TX into one VOS local TX.

  • An rdb_vos_tx_t handle is introduced to hide the vos/dtx details
    from the rest of rdb.

  • Some rdb_lc_discard calls are no longer necessary, for the VOS local
    TX mechanism will discard uncommited writes more efficiently.

  • Some "nvops" ("number of VOS TX operations") functions are added to
    provide dtx_begin with an upper bound of the number of VOS TX
    operations that will be invoked using a VOS TX handle. Hopefully
    this will become unnecessary in the future.

  • The rdb_tx_hdr decoding in rdb_tx_apply should use the actual length
    of the data, rather than the expected length.

  • Two places related to rdb_tx_hdr need to be refactored a bit in
    order to avoid compiler warnings along the line of "hdr may be used
    uninitialized". It's unclear why the compiler warnings suddenly come
    up.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions
Copy link

github-actions bot commented Jun 9, 2023 •
edited
Loading

Bug-tracker data:
Ticket title is 'Change RDB to use new extended VOS API'
Status is 'In Progress'
Labels: 'md_on_ssd'
https://daosio.atlassian.net/browse/DAOS-11406

daosbuild1
daosbuild1 reviewed Jun 9, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@liw liw force-pushed the liw/rdb-vos-tx branch from 00770ba to af4c8a4 Compare June 13, 2023 06:47
daosbuild1
daosbuild1 previously requested changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12330/2/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/2/execution/node/145/log

@liw liw requested review from jolivier23 and kccain June 13, 2023 06:53
@liw
Copy link
Contributor Author

liw commented Jun 13, 2023

@jolivier23, @kccain, just in case you are interested, I requested draft reviews to make this PR easier for you to find.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/2/execution/node/1242/log

@liw liw removed request for jolivier23 and kccain September 1, 2023 02:27
@daosbuild1 daosbuild1 dismissed their stale review November 27, 2023 02:40

Updated patch

daosbuild1
daosbuild1 reviewed Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daosbuild1
daosbuild1 reviewed Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@liw liw changed the title DAOS-11406 rdb: Use VOS local TX API DAOS-11406 rdb: Use VOS local TXs Dec 5, 2023
daosbuild1
daosbuild1 reviewed Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/5/execution/node/396/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/5/execution/node/362/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/5/execution/node/372/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.4 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/5/execution/node/306/log

daosbuild1
daosbuild1 reviewed Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/6/execution/node/388/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/6/execution/node/337/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/6/execution/node/364/log

daosbuild1
daosbuild1 reviewed Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@mchaarawi mchaarawi requested a review from a team as a code owner March 29, 2024 11:39
@liw
DAOS-11406 rdb: Use VOS local TXs
ea3d6eb 
Every RDB (update) TX invokes multiple VOS writes, each of which
performs a WAL commit. This patch reduces those WAL commits to one per
RDB TX by utilizing the new VOS local TXs to group all VOS writes of one
RDB TX into one VOS local TX.

  - An rdb_vos_tx_t handle is introduced to hide the vos/dtx details
    from the rest of rdb.

  - Some rdb_lc_discard calls are no longer necessary, for the VOS local
    TX mechanism will discard uncommited writes more efficiently.

  - Some "nvops" ("number of VOS TX operations") functions are added to
    provide dtx_begin with an upper bound of the number of VOS TX
    operations that will be invoked using a VOS TX handle. Hopefully
    this will become unnecessary in the future.

  - The rdb_tx_hdr decoding in rdb_tx_apply should use the actual length
    of the data, rather than the expected length.

  - Two places related to rdb_tx_hdr need to be refactored a bit in
    order to avoid compiler warnings along the line of "hdr may be used
    uninitialized". It's unclear why the compiler warnings suddenly come
    up.

Signed-off-by: Li Wei <[email protected]>
Required-githooks: true
@liw liw force-pushed the liw/rdb-vos-tx branch from 6067d34 to ea3d6eb Compare March 30, 2024 00:40
@liw
Copy link
Contributor Author

liw commented Mar 30, 2024

Rebased due to the base branch change. No code changes.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/26/execution/node/1544/log

@liw
Copy link
Contributor Author

liw commented Apr 1, 2024

daos_test/rebuild_simple: DAOS-15290

@liw liw requested review from kccain and NiuYawei April 1, 2024 01:29
NiuYawei
NiuYawei previously approved these changes Apr 1, 2024
View reviewed changes
kccain
kccain previously approved these changes Apr 5, 2024
View reviewed changes
@daosbuild1
Copy link
Collaborator

Test stage Build on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/27/execution/node/366/log

@daosbuild1
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/27/execution/node/370/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/27/execution/node/306/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/27/execution/node/322/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/27/execution/node/319/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/27/execution/node/433/log

@liw
Fix merge conflicts
ab43490 
Signed-off-by: Li Wei <[email protected]>
Required-githooks: true
@liw liw dismissed stale reviews from kccain and NiuYawei via ab43490 April 11, 2024 01:20
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12330/28/execution/node/1451/log

@liw
Copy link
Contributor Author

liw commented Apr 15, 2024

rebuild_simple REBUILD27: DAOS-15647

@liw liw requested a review from NiuYawei April 15, 2024 00:02
@liw liw requested a review from a team April 16, 2024 00:55
@gnailzenh gnailzenh merged commit b9b4f29 into master Apr 16, 2024
46 of 49 checks passed
@gnailzenh gnailzenh deleted the liw/rdb-vos-tx branch April 16, 2024 12:15
mchaarawi added a commit that referenced this pull request Apr 19, 2024
@mchaarawi
Revert "DAOS-11406 rdb: Use VOS local TXs (#12330)"
03d30b3 
This reverts commit b9b4f29.

Test-tag: test_daos_vol_mpich test_ior_small test_mdtest_small test_osa_online_drain_oclass test_create_pool_quantity test_aggregation_punching test_smallfilecount
Skip-func-hw-test-medium-md-on-ssd: false
Skip-func-hw-test-medium: true
Quick-Functional: true
Required-githooks: true

Signed-off-by: Mohamad Chaarawi <[email protected]>
Priority: 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@NiuYawei NiuYawei NiuYawei approved these changes

@gnailzenh gnailzenh gnailzenh approved these changes

@kccain kccain kccain approved these changes

@jolivier23 jolivier23 Awaiting requested review from jolivier23

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liw @daosbuild1 @NiuYawei @gnailzenh @kccain