Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-13386 cart: Execute CI tests with debug build of the UCX libraries. #12246

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

DAOS-13386 cart: Execute CI tests with debug build of the UCX libraries. #12246

wants to merge 19 commits into from

Conversation

jgmoore-or
Copy link
Contributor

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

jgmoore-or added 7 commits May 15, 2023 21:22
@jgmoore-or
DAOS-13386 cart: upgrade to UCX 1.14.
f230886 
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-build-ubuntu20-rpm: true
Skip-build-leap15-rpm: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-medium-verbs-provider: true
Test-provider: ucx+dc_x
PR-repos: openucx@PR-9:2

Signed-off-by: Joseph Moore <[email protected]>
@jgmoore-or
DAOS-13386 cart: Upgrade to UCX 1.14
c33d023 
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-build-ubuntu20-rpm: true
Skip-build-leap15-rpm: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-scan-rpms: rpms
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-medium-verbs-provider: true
Test-provider: ucx+dc_x
PR-repos: openucx@PR-9:2

Signed-off-by: Joseph Moore <[email protected]>
@jgmoore-or
DAOS-13386 cart: Upgrade to UCX 1.14.
b164196 
Sikip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-build-ubuntu20-rpm: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-medium-verbs-provider: true
Test-provider: ucx+dc_x
PR-repos: openucx@PR-9

Signed-off-by: Joseph Moore <[email protected]>
@jgmoore-or
DAOS-13386 cart: Upgrade to UCX 1.14
886a34f 
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-build-ubuntu20-rpm: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-medium-verbs-provider: true
Test-provider: ucx+dc_x
PR-repos: openucx@PR-9

Signed-off-by: Joseph Moore <[email protected]>
@jgmoore-or
Merge branch 'master' into jgm/daos-13386
5b2f1f8
@jgmoore-or
DAOS-13386 cart: Upgrade to UCX 1.14.
ba14a06 
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-build-ubuntu20-rpm: true
Skip-build-leap15-rpm: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-medium-verbs-provider: true
Test-provider: ucx+dc_x
PR-repos: openucx@PR-9:2

Signed-off-by: Joseph Moore <[email protected]>
@jgmoore-or
DAOS-13386 cart: Test with UCX 1.14 debug build.
5d48af3 
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-build-ubuntu20-rpm: true
Skip-build-leap15-rpm: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-medium-verbs-provider: true
Test-provider: ucx+dc_x
PR-repos: openucx@PR-9:3

Signed-off-by: Joseph Moore <[email protected]>
@jgmoore-or jgmoore-or marked this pull request as draft May 31, 2023 15:44
@github-actions
Copy link

github-actions bot commented May 31, 2023 •
edited
Loading

Bug-tracker data:
Ticket title is 'Update UCX version to 1.14.'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-13386

daosbuild1
daosbuild1 previously requested changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12246/1/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

src/cart/crt_init.c
@@ -307,6 +307,9 @@ static int data_init(int server, crt_init_options_t *opt)
if (server)
setenv("UCX_IB_FORK_INIT", "n", 1);

setenv("D_LOG_STDERR_IN_LOG", "1", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) code indent should use tabs where possible

src/cart/crt_init.c Outdated
@@ -307,6 +307,9 @@ static int data_init(int server, crt_init_options_t *opt)
if (server)
setenv("UCX_IB_FORK_INIT", "n", 1);

setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) code indent should use tabs where possible

src/cart/crt_init.c Outdated
Comment on lines 310 to 311
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/1/execution/node/138/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/1/execution/node/603/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/1/execution/node/556/log

@jgmoore-or jgmoore-or changed the title Jgm/daos 13386 2 DAOS-13386 cart: Execute CI tests with debug build of the UCX libraries. Jun 1, 2023
@daosbuild1 daosbuild1 dismissed their stale review June 1, 2023 16:33

Updated patch

daosbuild1
daosbuild1 previously requested changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12246/2/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

src/cart/crt_init.c
@@ -307,6 +307,9 @@ static int data_init(int server, crt_init_options_t *opt)
if (server)
setenv("UCX_IB_FORK_INIT", "n", 1);

setenv("D_LOG_STDERR_IN_LOG", "1", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) code indent should use tabs where possible

src/cart/crt_init.c Outdated
@@ -307,6 +307,9 @@ static int data_init(int server, crt_init_options_t *opt)
if (server)
setenv("UCX_IB_FORK_INIT", "n", 1);

setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) code indent should use tabs where possible

src/cart/crt_init.c Outdated
Comment on lines 310 to 311
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/2/execution/node/144/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/2/execution/node/601/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/2/execution/node/554/log

@daosbuild1 daosbuild1 dismissed their stale review June 1, 2023 23:24

Updated patch

daosbuild1
daosbuild1 previously requested changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12246/3/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

src/cart/crt_init.c
@@ -307,6 +307,9 @@ static int data_init(int server, crt_init_options_t *opt)
if (server)
setenv("UCX_IB_FORK_INIT", "n", 1);

setenv("D_LOG_STDERR_IN_LOG", "1", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) code indent should use tabs where possible

src/cart/crt_init.c Outdated
@@ -307,6 +307,9 @@ static int data_init(int server, crt_init_options_t *opt)
if (server)
setenv("UCX_IB_FORK_INIT", "n", 1);

setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) code indent should use tabs where possible

src/cart/crt_init.c Outdated
Comment on lines 310 to 311
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/3/execution/node/145/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/3/execution/node/601/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/3/execution/node/585/log

jgmoore-or added 2 commits June 2, 2023 17:47
@jgmoore-or
Merge branch 'master' into jgm/daos-13386-2
18f2c7c
@jgmoore-or
DAOS-12286 cart: Execute CI tests with debug build of the UCX libraries.
18e26a7 
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-build-ubuntu20-rpm: true
Skip-build-leap15-rpm: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-medium-verbs-provider: true
Test-provider: ucx+dc_x
PR-repos: openucx@PR-9:3

Signed-off-by: Joseph Moore <[email protected]>
@daosbuild1 daosbuild1 dismissed their stale review June 2, 2023 17:49

Updated patch

daosbuild1
daosbuild1 previously requested changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12246/4/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

src/cart/crt_init.c
@@ -307,6 +307,9 @@ static int data_init(int server, crt_init_options_t *opt)
if (server)
setenv("UCX_IB_FORK_INIT", "n", 1);

setenv("D_LOG_STDERR_IN_LOG", "1", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) code indent should use tabs where possible

src/cart/crt_init.c Outdated
@@ -307,6 +307,9 @@ static int data_init(int server, crt_init_options_t *opt)
if (server)
setenv("UCX_IB_FORK_INIT", "n", 1);

setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) code indent should use tabs where possible

src/cart/crt_init.c Outdated
Comment on lines 310 to 311
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/4/execution/node/145/log

@daosbuild1 daosbuild1 dismissed their stale review June 2, 2023 17:56

Updated patch

jgmoore-or added 2 commits June 7, 2023 17:11
@jgmoore-or
DAOS-13386 cart: Run with UCX debug build.
3a5be40 
Required-githooks: true

Signed-off-by: Joseph Moore <[email protected]>
@jgmoore-or
DAOS-13386 cart: Run with debug build for UCX.
1971169 
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-build-ubuntu20-rpm: true
Skip-build-leap15-rpm: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-medium-verbs-provider: true
Test-provider: ucx+dc_x
PR-repos: openucx@PR-9:3

Merge branch 'master' into jgm/daos-13386-2
@daosbuild1 daosbuild1 dismissed their stale review June 7, 2023 18:06

Updated patch

daosbuild1
daosbuild1 previously requested changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12246/12/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

src/cart/crt_init.c
@@ -307,6 +307,10 @@ static int data_init(int server, crt_init_options_t *opt)
if (server)
setenv("UCX_IB_FORK_INIT", "n", 1);

setenv("D_LOG_STDERR_IN_LOG", "1", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) code indent should use tabs where possible

src/cart/crt_init.c
@@ -307,6 +307,10 @@ static int data_init(int server, crt_init_options_t *opt)
if (server)
setenv("UCX_IB_FORK_INIT", "n", 1);

setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) code indent should use tabs where possible

src/cart/crt_init.c Outdated
@@ -307,6 +307,10 @@ static int data_init(int server, crt_init_options_t *opt)
if (server)
setenv("UCX_IB_FORK_INIT", "n", 1);

setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) code indent should use tabs where possible

src/cart/crt_init.c Outdated
Comment on lines 310 to 312
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/12/execution/node/144/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/12/execution/node/556/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/12/execution/node/603/log

@jgmoore-or
DAOS-13386 cart: Test with UCX debug build.
f94bc0c 
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-build-ubuntu20-rpm: true
Skip-build-leap15-rpm: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-medium-verbs-provider: true
Test-provider: ucx+rc_x
PR-repos: openucx@PR-9:3

Required-githooks: true

Signed-off-by: Joseph Moore <[email protected]>
@daosbuild1 daosbuild1 dismissed their stale review June 13, 2023 17:12

Updated patch

daosbuild1
daosbuild1 previously requested changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12246/13/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

src/cart/crt_init.c
@@ -307,6 +307,10 @@ static int data_init(int server, crt_init_options_t *opt)
if (server)
setenv("UCX_IB_FORK_INIT", "n", 1);

setenv("D_LOG_STDERR_IN_LOG", "1", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) code indent should use tabs where possible

src/cart/crt_init.c
@@ -307,6 +307,10 @@ static int data_init(int server, crt_init_options_t *opt)
if (server)
setenv("UCX_IB_FORK_INIT", "n", 1);

setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) code indent should use tabs where possible

src/cart/crt_init.c Outdated
@@ -307,6 +307,10 @@ static int data_init(int server, crt_init_options_t *opt)
if (server)
setenv("UCX_IB_FORK_INIT", "n", 1);

setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) code indent should use tabs where possible

src/cart/crt_init.c Outdated
Comment on lines 310 to 312
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1);
setenv("UCX_DC_MLX5_NUM_DCI", "16", 1);

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/13/execution/node/145/log

@jgmoore-or
DAOS-13386 cart: Test with UCX debug build.
c2d70ed 
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-build-ubuntu20-rpm: true
Skip-build-leap15-rpm: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-medium-verbs-provider: true
Test-provider: ucx+rc_x
PR-repos: openucx@PR-9:3

Required-githooks: true

Signed-off-by: Joseph Moore <[email protected]>
@daosbuild1 daosbuild1 dismissed their stale review June 13, 2023 17:46

Updated patch

daosbuild1
daosbuild1 previously requested changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12246/14/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

src/cart/crt_init.c
@@ -307,6 +307,9 @@ static int data_init(int server, crt_init_options_t *opt)
if (server)
setenv("UCX_IB_FORK_INIT", "n", 1);

setenv("D_LOG_STDERR_IN_LOG", "1", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) code indent should use tabs where possible

src/cart/crt_init.c
@@ -307,6 +307,9 @@ static int data_init(int server, crt_init_options_t *opt)
if (server)
setenv("UCX_IB_FORK_INIT", "n", 1);

setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) code indent should use tabs where possible

src/cart/crt_init.c
Comment on lines +310 to +311
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1);
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1);

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/14/execution/node/146/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/14/execution/node/604/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/14/execution/node/557/log

@jgmoore-or
DAOS-13386 cart: Run with UCX debug build.
7af02a9 
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-build-ubuntu20-rpm: true
Skip-build-leap15-rpm: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-medium-verbs-provider: true
Test-provider: ucx+ud_x
PR-repos: openucx@PR-9:3

Required-githooks: true

Signed-off-by: Joseph Moore <[email protected]>
@daosbuild1 daosbuild1 dismissed their stale review June 14, 2023 14:24

Updated patch

daosbuild1
daosbuild1 previously requested changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12246/15/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

src/cart/crt_init.c
@@ -307,6 +307,9 @@ static int data_init(int server, crt_init_options_t *opt)
if (server)
setenv("UCX_IB_FORK_INIT", "n", 1);

setenv("D_LOG_STDERR_IN_LOG", "1", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) code indent should use tabs where possible

src/cart/crt_init.c
@@ -307,6 +307,9 @@ static int data_init(int server, crt_init_options_t *opt)
if (server)
setenv("UCX_IB_FORK_INIT", "n", 1);

setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) code indent should use tabs where possible

src/cart/crt_init.c
Comment on lines +310 to +311
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1);
setenv("D_LOG_STDERR_IN_LOG", "1", 1);
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1);

@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/15/execution/node/145/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/15/execution/node/603/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/15/execution/node/587/log

@jgmoore-or
Merge branch 'master' into jgm/daos-13386-2
abb9b9f 
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-build-ubuntu20-rpm: true
Skip-build-leap15-rpm: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-medium-verbs-provider: true
Test-provider: ucx+dc_x
PR-repos: openucx@PR-9:15
@daosbuild1 daosbuild1 dismissed their stale review June 27, 2023 16:42

Updated patch

daosbuild1
daosbuild1 reviewed Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@jgmoore-or
DAOS-13386 ucx: Run with UCX debug build.
6749cd1 
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-build-ubuntu20-rpm: true
Skip-build-leap15-rpm: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-medium-verbs-provider: true
Test-provider: ucx+dc_x
PR-repos: openucx@PR-9:15

Required-githooks: true

Signed-off-by: Joseph Moore <[email protected]>
daosbuild1
daosbuild1 reviewed Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/17/execution/node/600/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12246/17/execution/node/601/log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgmoore-or @daosbuild1