-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-13268 cart: Fix UCX to use rdmacm. #12075
base: master
Are you sure you want to change the base?
Conversation
Test-provider: ucx+dc_x Required-githooks: true Signed-off-by: Joseph Moore <[email protected]>
Bug-tracker data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Skip-build-leap15-icc: true Skip-build-el8-gcc: true Skip-build-ubuntu20-rpm: true Skip-func-test-vm: true Skip-unit-tests: true Test-provider: ucx+dc_x Required-githooks: true Signed-off-by: Joseph Moore <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/2/execution/node/674/log |
Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/2/execution/node/814/log |
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/2/execution/node/721/log |
Skip-build-leap15-icc: true Skip-build-el8-gcc: true Skip-build-ubuntu20-rpm: true Skip-func-test-vm: true Skip-unit-tests: true Skip-func-hw-test-medium-verbs-provider: true Test-provider: ucx+dc_x Required-githooks: true Signed-off-by: Joseph Moore <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12075/3/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules
src/cart/crt_init.c
Outdated
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1); | ||
setenv("HG_LOG_LEVEL", "warning", 1); | ||
setenv("HG_LOG_SUBSYS", "na", 1); | ||
//setenv("D_LOG_STDERR_IN_LOG", "1", 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(style) do not use C99 // comments
src/cart/crt_init.c
Outdated
setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1); | ||
setenv("HG_LOG_LEVEL", "warning", 1); | ||
setenv("HG_LOG_SUBSYS", "na", 1); | ||
//setenv("D_LOG_STDERR_IN_LOG", "1", 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//setenv("D_LOG_STDERR_IN_LOG", "1", 1); | |
/* setenv("D_LOG_STDERR_IN_LOG", "1", 1); */ |
Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/3/execution/node/145/log |
Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/3/execution/node/289/log |
Test stage Build RPM on Leap 15.4 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/3/execution/node/292/log |
Skip-build-leap15-icc: true Skip-build-el8-gcc: true Skip-build-ubuntu20-rpm: true Skip-func-test-vm: true Skip-unit-tests: true Skip-func-hw-test-medium-verbs-provider: true Test-provider: ucx+dc_x Required-githooks: true Signed-off-by: Joseph Moore <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12075/4/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules
src/cart/crt_init.c
Outdated
@@ -307,6 +307,12 @@ static int data_init(int server, crt_init_options_t *opt) | |||
if (server) | |||
setenv("UCX_IB_FORK_INIT", "n", 1); | |||
|
|||
//setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(style) do not use C99 // comments
src/cart/crt_init.c
Outdated
@@ -307,6 +307,12 @@ static int data_init(int server, crt_init_options_t *opt) | |||
if (server) | |||
setenv("UCX_IB_FORK_INIT", "n", 1); | |||
|
|||
//setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1); | |
/* setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1); */ |
Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/4/execution/node/119/log |
Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/4/execution/node/289/log |
Test stage Build RPM on Leap 15.4 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/4/execution/node/292/log |
Skip-build-leap15-icc: true Skip-build-el8-gcc: true Skip-build-ubuntu20-rpm: true Skip-func-test-vm: true Skip-unit-tests: true Skip-func-hw-test-medium-verbs-provider: true Test-provider: ucx+dc_x Required-githooks: true Signed-off-by: Joseph Moore <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-12075/5/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules
src/cart/crt_init.c
Outdated
@@ -307,6 +307,12 @@ static int data_init(int server, crt_init_options_t *opt) | |||
if (server) | |||
setenv("UCX_IB_FORK_INIT", "n", 1); | |||
|
|||
//setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(style) do not use C99 // comments
src/cart/crt_init.c
Outdated
@@ -307,6 +307,12 @@ static int data_init(int server, crt_init_options_t *opt) | |||
if (server) | |||
setenv("UCX_IB_FORK_INIT", "n", 1); | |||
|
|||
//setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1); | |
/* setenv("UCX_SOCKADDR_TLS_PRIORITY", "rdmacm", 1); */ |
Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/5/execution/node/144/log |
Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/5/execution/node/719/log |
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/5/execution/node/672/log |
Skip-build-leap15-icc: true Skip-build-el8-gcc: true Skip-build-ubuntu20-rpm: true Skip-func-test-vm: true Skip-unit-tests: true Skip-func-hw-test-medium-verbs-provider: true Skip-func-hw-test-medium-ucx-provider: false Test-provider: ucx+dc_x Required-githooks: true Signed-off-by: Joseph Moore <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/6/execution/node/672/log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/20/execution/node/611/log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/21/execution/node/642/log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/22/execution/node/611/log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-12075/23/testReport/(root)/ |
Skip-build-el8-gcc: true Skip-build-ubuntu20-rpm: true Skip-func-test-vm: true Skip-unit-tests: true Skip-scan-leap15-rpms: true Skip-func-hw-test-medium-ucx-provider: false Skip-func-hw-test-medium-verbs-provider: true Test-provider: ucx+dc_x PR-repos: mercury@PR-100:5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/24/execution/node/699/log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/25/execution/node/660/log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/26/execution/node/660/log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/27/execution/node/660/log |
Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/27/execution/node/753/log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Build on Leap 15.4 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/28/execution/node/294/log |
Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/28/execution/node/333/log |
Test stage Build RPM on Leap 15.4 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/28/execution/node/290/log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/29/execution/node/660/log |
Skip-build-el8-gcc: true Skip-build-ubuntu20-rpm: true Skip-func-test-vm: true Skip-unit-tests: true Skip-func-hw-test-medium-ucx-provider: false Skip-func-hw-test-medium-verbs-provider: true Test-provider: ucx+dc_x Required-githooks: true Signed-off-by: Joseph Moore <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/30/execution/node/768/log |
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-12075/30/execution/node/721/log |
Skip-build-leap15-icc: true Skip-build-el8-gcc: true Skip-build-ubuntu20-rpm: true Skip-build-leap15-rpm: true Skip-func-test-vm: true Skip-unit-tests: true Skip-func-hw-test-medium-ucx-provider: false Skip-func-hw-test-medium-verbs-provider: true Test-provider: ucx+dc_x PR-repos: openucx@PR-9:2 Required-githooks: true Signed-off-by: Joseph Moore <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test-provider: ucx+dc_x
Required-githooks: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: