DAOS-15799 build: Add libsanitize

Add libsanitize for debugging stack smashing occuring on LRZ servers. Skip-test: true Required-githooks: true Signed-off-by: Cedric Koch-Hofer <[email protected]>
daos-stack · May 31, 2024 · aa4faec · aa4faec
1 parent bf9ac88
commit aa4faec
Show file tree

Hide file tree

Showing 16 changed files with 24 additions and 11 deletions.
diff --git a/site_scons/site_tools/compiler_setup.py b/site_scons/site_tools/compiler_setup.py
@@ -18,6 +18,9 @@
 # Compiler flags for stack hardening
 DESIRED_FLAGS.extend(['-fstack-protector-strong', '-fstack-clash-protection'])
 
+# Compiler flags for fast memory error detector
+DESIRED_FLAGS.extend(['-fsanitize=address'])
+
 PP_ONLY_FLAGS = ['-Wno-parentheses-equality', '-Wno-builtin-requires-header',
                  '-Wno-unused-function']
 

diff --git a/src/bio/SConscript b/src/bio/SConscript
@@ -32,7 +32,7 @@ def scons():
     libs += ['spdk_vmd', 'spdk_event_bdev', 'spdk_init']
 
     # Other libs
-    libs += ['numa', 'dl', 'smd']
+    libs += ['numa', 'dl', 'smd', 'asan']
 
     tgts = FILES + control_tgts
     bio = denv.d_library("bio", tgts, install_off="../..", LIBS=libs)

diff --git a/src/common/SConscript b/src/common/SConscript
@@ -19,7 +19,7 @@ def build_daos_common(denv, client):
     ad_mem_files = []
     dav_src = []
 
-    common_libs = ['isal', 'isal_crypto', 'cart', 'gurt', 'lz4', 'protobuf-c', 'uuid', 'pthread']
+    common_libs = ['isal', 'isal_crypto', 'cart', 'gurt', 'lz4', 'protobuf-c', 'uuid', 'pthread', 'asan']
     if client:
         libname = 'daos_common'
     else:

diff --git a/src/control/SConscript b/src/control/SConscript
@@ -76,7 +76,7 @@ def install_go_bin(env, name, libs=None, install_man=False):
 
     if libs is None:
         libs = []
-    libs.extend(['daos_common', 'cart', 'gurt'])
+    libs.extend(['daos_common', 'cart', 'gurt', 'asan'])
 
     target = env.d_run_command(name, sources, libs,
                                f'cd {gosrc}; {env.d_go_bin} build -mod vendor '

diff --git a/src/control/lib/spdk/SConscript b/src/control/lib/spdk/SConscript
@@ -22,7 +22,7 @@ def scons():
     libs += ['rte_mempool_ring', 'rte_bus_pci']
 
     # Other libs
-    libs += ['numa', 'dl']
+    libs += ['numa', 'dl', 'asan']
 
     nc_obj = senv.Object("src/nvme_control.c")
     ncc_obj = senv.Object("src/nvme_control_common.c")

diff --git a/src/control/lib/spdk/ctests/SConscript b/src/control/lib/spdk/ctests/SConscript
@@ -23,7 +23,7 @@ def scons():
     libs += ['rte_mempool_ring', 'rte_bus_pci', 'nvme_control']
 
     # Other libs
-    libs += ['numa', 'dl', 'isal', 'cmocka', 'pthread']
+    libs += ['numa', 'dl', 'isal', 'cmocka', 'pthread', 'asan']
 
     if GetOption('help'):
         return

diff --git a/src/tests/drpc/SConscript b/src/tests/drpc/SConscript
@@ -5,7 +5,7 @@ def scons():
     """Execute build"""
     Import('env')
 
-    libs = ['daos_common', 'gurt', 'protobuf-c']
+    libs = ['daos_common', 'gurt', 'protobuf-c', 'asan']
     sources = ['drpc_test.c', 'drpc_test.pb-c.c']
 
     denv = env.Clone()

diff --git a/src/tests/rpc/SConscript b/src/tests/rpc/SConscript
@@ -5,7 +5,7 @@ def scons():
     """Execute build"""
     Import('env')
 
-    libs = ['daos', 'daos_common', 'cmocka', 'gurt']
+    libs = ['daos', 'daos_common', 'cmocka', 'gurt', 'asan']
     sources = ['rpc_tests.c']
 
     denv = env.Clone()

diff --git a/src/tests/security/SConscript b/src/tests/security/SConscript
@@ -5,7 +5,7 @@ def scons():
     """Execute build"""
     Import('env', 'dc_sectest_tgts')
 
-    libs = ['$LIBS', 'daos', 'daos_common', 'gurt']
+    libs = ['$LIBS', 'daos', 'daos_common', 'gurt', 'asan']
     sec_sources = ['security_test.c', dc_sectest_tgts]
     acl_sources = ['acl_dump_test.c']
 

diff --git a/src/utils/SConscript b/src/utils/SConscript
@@ -31,7 +31,7 @@ def scons():
     denv = env.Clone()
     denv.AppendUnique(LIBPATH=[Dir('../client/dfs')])
     denv.AppendUnique(CPPPATH=[Dir('../client/dfs').srcnode()])
-    libs = ['daos', 'daos_common', 'uuid', 'dfs', 'duns', 'gurt', 'cart', 'dl']
+    libs = ['daos', 'daos_common', 'uuid', 'dfs', 'duns', 'gurt', 'cart', 'dl', 'asan']
 
     daos_hdlrs_src = ['daos_hdlr.c', 'daos_autotest.c', 'daos_dfs_hdlr.c']
     daos_hdlrs_lib = denv.d_library('daos_cmd_hdlrs', daos_hdlrs_src, LIBS=libs)

diff --git a/src/utils/crt_launch/SConscript b/src/utils/crt_launch/SConscript
@@ -9,7 +9,7 @@ def scons():
 
     tenv = env.Clone()
 
-    libs = ['dpar', 'cart', 'gurt', 'pthread', 'm']
+    libs = ['dpar', 'cart', 'gurt', 'pthread', 'm', 'asan']
 
     tenv.AppendUnique(LIBS=libs)
     tenv.require('mercury')

diff --git a/utils/rpms/daos.spec b/utils/rpms/daos.spec
@@ -15,7 +15,7 @@
 
 Name:          daos
 Version:       2.4.2
-Release:       4%{?relval}%{?dist}
+Release:       5%{?relval}%{?dist}
 Summary:       DAOS Storage Engine
 
 License:       BSD-2-Clause-Patent
@@ -114,6 +114,9 @@ BuildRequires: libuct-devel
 BuildRequires: ucx-devel
 %endif
 
+# Needed for support tasks
+BuildRequires: libasan
+
 Requires: openssl
 # This should only be temporary until we can get a stable upstream release
 # of mercury, at which time the autoprov shared library version should
@@ -555,6 +558,9 @@ getent passwd daos_agent >/dev/null || useradd -s /sbin/nologin -r -g daos_agent
 # No files in a shim package
 
 %changelog
+* Fri May 31 2024 Cedric Koch-Hofer <[email protected]> 2.4.2-5
+- Support release candidate for 2.4.2
+
 * Mon Mar 04 2024 Phillip Henderson <[email protected]> 2.4.2-4
 - Third release candidate for 2.4.2
 

diff --git a/utils/scripts/install-el8.sh b/utils/scripts/install-el8.sh
@@ -37,6 +37,7 @@ dnf --nodocs install \
     java-1.8.0-openjdk \
     json-c-devel \
     libaio-devel \
+    lbasan \
     libcmocka-devel \
     libevent-devel \
     libiscsi-devel \

diff --git a/utils/scripts/install-el9.sh b/utils/scripts/install-el9.sh
@@ -36,6 +36,7 @@ dnf --nodocs install \
     java-1.8.0-openjdk \
     json-c-devel \
     libaio-devel \
+    libasan \
     libcmocka-devel \
     libevent-devel \
     libipmctl-devel \

diff --git a/utils/scripts/install-leap15.sh b/utils/scripts/install-leap15.sh
@@ -31,6 +31,7 @@ dnf --nodocs install \
     hwloc-devel \
     java-1_8_0-openjdk-devel \
     libaio-devel \
+    libasan \
     libcmocka-devel \
     libcapstone-devel \
     libevent-devel \

diff --git a/utils/scripts/install-ubuntu.sh b/utils/scripts/install-ubuntu.sh
@@ -26,6 +26,7 @@ apt-get install \
     golang-go \
     kmod \
     libaio-dev \
+    libasan8 \
     libboost-dev \
     libcapstone-dev \
     libcmocka-dev \