-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSH Tunnel support #246
SSH Tunnel support #246
Conversation
…nvironment to play with
…tunnel connection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an excellent feature!!!
return nil, err | ||
} | ||
|
||
defer sshConfig.Close() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this result in the ssh tunnel closing before the application closes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SSH tunnel support
Description
This PR adds support for SSH Tunnel as requested many times in #205. It adds 6 new flags to the cli tool to perform the connection.
e.g.
This change only adds support for
MySQL
andPostgres
, more to come later.Fixes #205
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
A new docker compose file has been added to the development environment, adding a service called
ssh
, withubuntu-sshd
being its underlying base image to act as the ssh server to test the connection against.Also, a mock ssh server has been added to the test suite, to validate the use of the private key file as authentication method.
Checklist: