Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to look for the config file in $XDG_CONFIG_HOME #197

Merged

Conversation

timetravel-1010
Copy link
Contributor

Description

Added support to look for the config file in the $XDG_CONFIG_HOME path using the os package.

I've also updated the documentation in the necessary files, I think.

Implements #194

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

The test suite ran successfully.

I didn't add any unit test in the config_test.go file. I tested (on Ubuntu) putting the .dblab.yaml in my $XDG_CONFIG_HOME path though.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@timetravel-1010 timetravel-1010 changed the title Feature/xdg config support 194 feat: add support to look for the config file in $XDG_CONFIG_HOME Apr 28, 2024
@danvergara danvergara self-requested a review April 29, 2024 16:05
@danvergara danvergara added kind/enhancement New feature or request intermediate Good for intermediate developers labels Apr 29, 2024
Copy link
Owner

@danvergara danvergara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just test this out locally.

It worked out!!

Thanks @timetravel-1010!

@danvergara danvergara merged commit d9a4d74 into danvergara:main Apr 30, 2024
4 checks passed
@timetravel-1010
Copy link
Contributor Author

Just test this out locally.

It worked out!!

Thanks @timetravel-1010!

You're welcome, happy to help/

P.D: I think #194 can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intermediate Good for intermediate developers kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants