Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/issue: add feature request template #921

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

doc/issue: add feature request template #921

wants to merge 7 commits into from
+125 −0

Conversation

Flameopathic
Copy link
Contributor

adds a basic feature request issue template

@Flameopathic Flameopathic force-pushed the github-issue-templates branch 4 times, most recently from 4c749b0 to 2901212 Compare February 25, 2025 19:50
trueNAHO
trueNAHO requested changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could pick #516 back up so we could maybe merge them together.

@Flameopathic Flameopathic force-pushed the github-issue-templates branch from 2901212 to 2cfdf6b Compare February 27, 2025 20:23
@Flameopathic Flameopathic requested a review from trueNAHO March 1, 2025 19:47
trueNAHO
trueNAHO requested changes Mar 4, 2025
View reviewed changes
trueNAHO
trueNAHO requested changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@trueNAHO trueNAHO left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could further split change-target, since it might be one of the most common issues. However, the current state is probably good enough for now.

However, we might want to add a generic issues regarding bugs or something not working as intended or expected.

.github/ISSUE_TEMPLATE/changeoption.yml
Comment on lines +16 to +20
options:
- label: >-
I have searched for and not found existing issues requesting this
change.
required: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not very familiar with GitHub templates. Is it possible to make this a simple checkbox:

  • This is not a duplicate issue.

Would this even be better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can simplify if you would like, but it is not possible to have a checkbox without a label above and to the side of it. The description is optional, though.

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema#checkboxes

@Flameopathic
Copy link
Contributor Author

We could further split change-target, since it might be one of the most common issues. However, the current state is probably good enough for now.

agreed.

However, we might want to add a generic issues regarding bugs or something not working as intended or expected.

absolutely; would you pick back up #516? i think that what you have there is pretty good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueNAHO trueNAHO trueNAHO requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Flameopathic @trueNAHO