Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDFBRA-396 - Added update hook for installing "graphql_compose_routes" module. #1999

Merged

Conversation

Dresse
Copy link
Contributor

@Dresse Dresse commented Jan 22, 2025

Link to issue

https://reload.atlassian.net/browse/DDFBRA-396

Description

Added update hook for installing "graphql_compose_routes" module.

The module was enabled in config core.extensions.yml in a previous PR.

Copy link
Collaborator

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to remove it from core.extensions?

@Dresse
Copy link
Contributor Author

Dresse commented Jan 22, 2025

Do you need to remove it from core.extensions?

We usually have it both places actually. So I don't think it should be removed from core.extensions.yml

@spaceo spaceo self-requested a review January 22, 2025 14:46
Copy link
Collaborator

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Dresse Dresse merged commit a8b34ce into develop Jan 22, 2025
21 checks passed
@Dresse Dresse deleted the DDFBRA-396-enable-graphql-compose-routes-module-in-update-hook branch January 22, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants