-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDFBRA-390 - Added GO Material Slider paragraphs #1997
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- GO Material Slider - Automatic - GO Material Slider - Manual Enabled both of them for all GO specific content types (GO Article, GO Category, GO Page) Enabled both paragraphs in GraphQL Compose. Also enabled GO Linkbox paragraph for all GO specific content types and enabled it in GraphQL Compose.
spaceo
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Najs. LGTM 👍
I have some comments
web/modules/custom/dpl_graphql/src/Plugin/GraphQLCompose/FieldType/CqlSearchItem.php
Outdated
Show resolved
Hide resolved
web/modules/custom/dpl_graphql/src/Plugin/GraphQLCompose/SchemaType/WorkIdType.php
Outdated
Show resolved
Hide resolved
Dresse
force-pushed
the
DDFBRA-390-add-material-slider-paragraphs
branch
from
January 22, 2025 11:54
7b188e5
to
32009c4
Compare
In the WorkIdType renamed the field "value" -> "work_id" for better readability.
Dresse
force-pushed
the
DDFBRA-390-add-material-slider-paragraphs
branch
from
January 22, 2025 12:27
32009c4
to
1b6284c
Compare
Fixed typo in the "GO Material Slider - Manual" paragraph. Renamed it from "Mannual" -> "Manual"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-390
Description
Added two new GO paragraphs:
Enabled both of them for all GO specific content types (GO Article, GO Category, GO Page)
Enabled both paragraphs in GraphQL Compose.
Also enabled GO Linkbox paragraph for all GO specific content types and enabled it in GraphQL Compose.
Screenshot of the result
GO Material Slider - Automatic in Drupal backend:
GO Material Slider - Manual in Drupal backend:
Additional comments or questions
Example GraphQL query for fetching a GO Page containing a both "GO Material Slider - Automatic" and "GO Material Slider - Manual":
Result