ci: add revive to CI

.github/workflows/build-test-lint.yml

@@ -26,6 +26,7 @@ jobs:
           go install github.com/segmentio/[email protected]
           go install mvdan.cc/[email protected]
           go install github.com/securego/gosec/v2/cmd/[email protected]
+          go install github.com/mgechev/[email protected]
 
       - name: Build
         run: make build

Makefile

@@ -4,6 +4,7 @@ help: ## Show this help
 	@egrep -h '\s##\s' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-12s\033[0m %s\n", $$1, $$2}'
 
 lint: tidy ## Run linter
+	revive -config revive.toml -exclude vendor/...  ./...
 	golines -m 79 --base-formatter=gofumpt .
 	gosec ./...
 	go vet ./...

cmd/geoblock/main.go

@@ -1,3 +1,4 @@
+// Package main contains the main geoblock application.
 package main
 
 import (

pkg/database/database.go

@@ -1,3 +1,4 @@
+// Package database provides a database of IP ranges and their associated data.
 package database
 
 import (

pkg/rules/engine.go

@@ -1,3 +1,4 @@
+// Package rules contains all rules related logic.
 package rules
 
 import (

pkg/schema/reader.go

@@ -1,3 +1,4 @@
+// Package schema contains configiguration schema used by geoblock.
 package schema
 
 import (

pkg/server/server.go

@@ -1,3 +1,4 @@
+// Package server contains the HTTP authorization server.
 package server
 
 import (
@@ -38,6 +39,8 @@ func getForwardAuth(
 	resolver *database.Resolver,
 	engine *rules.Engine,
 ) {
+	log.Info(request.Method)
+
 	origin := request.Header.Get(HeaderXForwardedFor)
 	domain := request.Header.Get(HeaderXForwardedHost)
 

pkg/utils/duration.go

@@ -1,3 +1,4 @@
+// Package utils contains utility functions used by geoblock.
 package utils
 
 import (

revive.toml

@@ -0,0 +1,29 @@
+ignoreGeneratedHeader = false
+severity = "warning"
+confidence = 0.8
+errorCode = 1
+warningCode = 2
+
+[rule.blank-imports]
+[rule.context-as-argument]
+[rule.context-keys-type]
+[rule.dot-imports]
+[rule.error-return]
+[rule.error-strings]
+[rule.error-naming]
+[rule.exported]
+[rule.increment-decrement]
+[rule.var-naming]
+[rule.var-declaration]
+[rule.package-comments]
+[rule.range]
+[rule.receiver-naming]
+[rule.time-naming]
+[rule.unexported-return]
+[rule.indent-error-flow]
+[rule.errorf]
+[rule.empty-block]
+[rule.superfluous-else]
+[rule.unused-parameter]
+[rule.unreachable-code]
+[rule.redefines-builtin-id]