Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: Await saveMessage in abortMiddleware to ensure proper execution #6248

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

sh4shii
Copy link
Contributor

@sh4shii sh4shii commented Mar 9, 2025

Summary

Closes:- #5774 #5776

Fixed a potential async operation issue in the abort middleware where saveMessage was called without await. This could lead to unhandled promises and potential race conditions in message handling. Previous code was not properly awaiting an async operation, which could lead to unexpected behavior. This fix ensures the async operation completes before continuing execution.

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

Test Configuration:

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

@danny-avila danny-avila merged commit a53638c into danny-avila:main Mar 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants