Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔏 fix: Enhance Two-Factor Authentication #6247

Merged
merged 4 commits into from
Mar 8, 2025
Merged

Conversation

rubentalstra
Copy link
Collaborator

Summary

This pull request includes significant changes to the two-factor authentication (2FA) implementation, as well as some updates to the data-schemas package. The most important changes involve adding a twoFactorEnabled field to the user model, updating related controllers and components, and licensing updates.

Improvements to 2FA implementation:

Updates to data-schemas package:

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

Please describe your test process and include instructions so that we can reproduce your test. If there are any important variables for your testing configuration, list them here.

Test Configuration:

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

@rubentalstra rubentalstra added 🔧 fix Bug fixes and code patches 🔥 hotfix Urgent production fixes labels Mar 8, 2025
@rubentalstra rubentalstra self-assigned this Mar 8, 2025
@rubentalstra rubentalstra requested a review from danny-avila March 8, 2025 20:12
@danny-avila danny-avila changed the title Fix: 2fa enable issue 🔏 fix: Enhance Two-Factor Authentication Mar 8, 2025
@danny-avila danny-avila merged commit 3e3dfe5 into main Mar 8, 2025
7 checks passed
@danny-avila danny-avila deleted the fix/2fa-enable-issue branch March 8, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 fix Bug fixes and code patches 🔥 hotfix Urgent production fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants