Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 fix: Add Null Checks for BaseURL in Agent Config #5908

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Feb 16, 2025

Summary:

I addressed a runtime error encountered in issue #5904 by adding null checks to the LLM configuration. This ensures that the baseURL and reverseProxyUrl are verified before invoking string methods.

  • Added an optional chaining check for baseURL in run.js to safely call the includes method
  • Bug introduced in 🧠 feat: Reasoning UI for Agents #5904
  • Updated the condition in llm.js by verifying that reverseProxyUrl exists before using includes.

Closes #5907

@danny-avila danny-avila changed the title 🐞 fix: Add Null Checks for BaseURL in LLM Configuration 🐞 fix: Add Null Checks for BaseURL in Agent Config Feb 16, 2025
@danny-avila danny-avila merged commit 93dd365 into main Feb 16, 2025
5 checks passed
@danny-avila danny-avila deleted the fix/agent-null-check branch February 16, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: OpenAI Models dont work for Agents
1 participant