Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 fix: Handle Google social login with missing last name #5884

Closed
wants to merge 1 commit into from

Conversation

DPK101
Copy link
Contributor

@DPK101 DPK101 commented Feb 14, 2025

Summary

Social login with Google was previously displaying 'undefined' when a user's last name was empty or not provided.

GoogleAccountLastName_undefined

Changes:

  • Conditionally render last name only if it exists
  • Prevent displaying 'undefined' when last name is missing

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

  • To verify this, one should use Google account without last name for account registration through social login
  • After succesful registration, verify that profile name doesn't include 'undefined' as last name (bottom left corner)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings
  • Local unit tests pass with my changes

Social login with Google was previously displaying 'undefined' when
a user's last name was empty or not provided.

Changes:
- Conditionally render last name only if it exists
- Prevent displaying 'undefined' when last name is missing
@danny-avila
Copy link
Owner

Thanks! Merging your commit in #5904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants