Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 ci: Fix Conversation Grouping Tests #1773

Merged
merged 1 commit into from
Feb 11, 2024
Merged

🧪 ci: Fix Conversation Grouping Tests #1773

merged 1 commit into from
Feb 11, 2024

Conversation

danny-avila
Copy link
Owner

Summary

I've updated the fakeData updatedAt field to be dynamic, always set to 3 days before today's date. This change ensures that the test data reflects a more realistic scenario for our CI testing environment. Additionally, I've enhanced type safety for the fakeData values and removed fields that were deemed unnecessary, streamlining the test data object.

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

To ensure the dynamic updatedAt field works correctly, I tested it by running the CI tests and observing that the date is indeed set to 3 days before the current date. The type safety and removal of unnecessary fields were validated by reviewing the fakeData object structure and ensuring no runtime errors occurred.

Test Configuration:

  • Date verification: Ensuring the updatedAt field correctly reflects 3 days prior to the current date.
  • Type safety checks: Reviewing the fakeData object structure for any type-related issues.
  • CI test environment: Running the existing CI tests to confirm no disruptions caused by the changes.

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes

…), also use typesafe values and remove unnecessary fields
@danny-avila danny-avila merged commit 50adb1b into main Feb 11, 2024
1 check passed
@danny-avila danny-avila deleted the ci-convos-test branch February 11, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant