Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Maximum Temperature for OpenAI endpoint set to 1 instead of 2 (which would result in gibberish output above a temperature 1) #1749

Closed
wants to merge 4 commits into from

Conversation

marlonka
Copy link
Contributor

@marlonka marlonka commented Feb 7, 2024

Summary

fix: I changed the maximum Temperature for OpenAI endpoint to 1 instead of 2 , because anything above 1 would result in gibberish output. See the OpenAI playground for example. There OpenAI sets the maximum temperature also to 1.
Unexperienced users can set it to too high values without this fix resulting in unnecessary problems.

(Second idea would be to decrease steps from 0.01 to 0.1, since 0.01 steps is way to granular)

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

I build the docker container new and tested if the changes work well in front-end and correctly work with OpenAI endpoint by testing some messages. Its better now this way.

Test Configuration:

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

@RedwindA
Copy link
Contributor

RedwindA commented Feb 8, 2024

It's better to implement it as a toggleable default option, hidden in the settings menu.

@danny-avila
Copy link
Owner

Thanks for the PR, but I'm not sure this is necessary. The API allows up to 2 and I would not like to intentionally limit it: https://platform.openai.com/docs/api-reference/chat/create#chat-create-temperature

@danny-avila danny-avila closed this Feb 8, 2024
@marlonka
Copy link
Contributor Author

marlonka commented Feb 8, 2024

yeah okay, maybe there could be beginner and advanced settings in future in the ui

@RedwindA
Copy link
Contributor

now it's 1😢😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants