Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 fix: check allowed domains for social logins #1734

Closed
wants to merge 9 commits into from

Conversation

berry-13
Copy link
Collaborator

@berry-13 berry-13 commented Feb 5, 2024

Summary

added check of allowed domains for social login

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

tested if every social login works properly

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

@badcom
Copy link
Contributor

badcom commented Feb 17, 2024

What's missing to merge this?

@badcom
Copy link
Contributor

badcom commented Mar 16, 2024

@danny-avila Please review this 😊

@danny-avila
Copy link
Owner

@danny-avila Please review this 😊

Sorry for the long wait on this @badcom want to get this done

@badcom
Copy link
Contributor

badcom commented Apr 7, 2024

Appreciate it :)

@berry-13
Copy link
Collaborator Author

@danny-avila tests fixed!

@danny-avila
Copy link
Owner

See comment here: #1734

@berry-13 berry-13 deleted the fix-allow-domains branch November 22, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants