This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Fixed accessibility issues #453
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two 508 compliance errors: -The header (th) element with the checkbox for "Select All" is empty. -The header (th) element with the progress bar is also empty. The fix was to add hidden text for the "Select All" header, and change the <th> element to a regular <td> for the progress bar.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using your data table for a few days but I found a couple of defects in accessibility. These errors make page readers like JAWS behave erratically. Since it's my personal goal to help little by little to make Internet more accessible to blind people, I forked your project to fix two issues.
There are two 508 compliance errors I found using the Wave toolbar are these:
-The header (th) element with the checkbox for "Select All" is empty.
-The header (th) element with the progress bar is also empty.
Here are some screen shots showing the validator failing.
Here is the accessibility rule for this issue: http://webaim.org/standards/508/checklist#standardg
The fix was to add hidden text for the "Select All" header, and change the "th" element to a regular "td" for the progress bar.
I hope you take this pull request and make it available soon in bower and npm repos.
Regards!