i guess we need key for some reason.

dalinicus · Jan 28, 2025 · 065b362 · 065b362
1 parent 64526a2
commit 065b362
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 5 deletions.
diff --git a/custom_components/ac_infinity/sensor.py b/custom_components/ac_infinity/sensor.py
@@ -54,6 +54,7 @@
 class ACInfinitySensorEntityDescription(SensorEntityDescription):
     """Describes ACInfinity Number Sensor Entities."""
 
+    key: str
     icon: str | None
     translation_key: str | None
     device_class: SensorDeviceClass | None
@@ -68,8 +69,6 @@ class ACInfinityControllerSensorEntityDescription(
 ):
     """Describes ACInfinity Controller Sensor Entities."""
 
-    key: str
-
 
 @dataclass
 class ACInfinitySensorSensorEntityDescription(
@@ -84,8 +83,6 @@ class ACInfinityPortSensorEntityDescription(
 ):
     """Describes ACInfinity Device Sensor Entities."""
 
-    key: str
-
 
 def __suitable_fn_controller_property_default(
     entity: ACInfinityEntity, controller: ACInfinityController
@@ -269,6 +266,8 @@ def __get_next_mode_change_timestamp(
 
 SENSOR_DESCRIPTIONS: dict[int, ACInfinitySensorSensorEntityDescription] = {
     SensorType.PROBE_TEMPERATURE: ACInfinitySensorSensorEntityDescription(
+        # key is not used for sensors.
+        key="probeTemperature",
         device_class=SensorDeviceClass.TEMPERATURE,
         state_class=SensorStateClass.MEASUREMENT,
         native_unit_of_measurement=UnitOfTemperature.CELSIUS,
@@ -279,6 +278,7 @@ def __get_next_mode_change_timestamp(
         get_value_fn=__get_value_fn_sensor_value_temperature,
     ),
     SensorType.PROBE_HUMIDITY: ACInfinitySensorSensorEntityDescription(
+        key="probeHumidity",
         device_class=SensorDeviceClass.HUMIDITY,
         state_class=SensorStateClass.MEASUREMENT,
         native_unit_of_measurement=PERCENTAGE,
@@ -289,6 +289,7 @@ def __get_next_mode_change_timestamp(
         get_value_fn=__get_value_fn_sensor_value_default,
     ),
     SensorType.PROBE_VPD: ACInfinitySensorSensorEntityDescription(
+        key="probeVaporPressureDeficit",
         device_class=SensorDeviceClass.PRESSURE,
         state_class=SensorStateClass.MEASUREMENT,
         suggested_unit_of_measurement=UnitOfPressure.KPA,
@@ -299,6 +300,7 @@ def __get_next_mode_change_timestamp(
         get_value_fn=__get_value_fn_sensor_value_default,
     ),
     SensorType.EXTERNAL_TEMPERATURE: ACInfinitySensorSensorEntityDescription(
+        key="externalTemperature",
         device_class=SensorDeviceClass.TEMPERATURE,
         state_class=SensorStateClass.MEASUREMENT,
         native_unit_of_measurement=UnitOfTemperature.CELSIUS,
@@ -309,6 +311,7 @@ def __get_next_mode_change_timestamp(
         get_value_fn=__get_value_fn_sensor_value_temperature,
     ),
     SensorType.EXTERNAL_HUMIDITY: ACInfinitySensorSensorEntityDescription(
+        key="externalHumidity",
         device_class=SensorDeviceClass.HUMIDITY,
         state_class=SensorStateClass.MEASUREMENT,
         native_unit_of_measurement=PERCENTAGE,
@@ -319,6 +322,7 @@ def __get_next_mode_change_timestamp(
         get_value_fn=__get_value_fn_sensor_value_default,
     ),
     SensorType.EXTERNAL_VPD: ACInfinitySensorSensorEntityDescription(
+        key="externalVaporPressureDeficit",
         device_class=SensorDeviceClass.PRESSURE,
         state_class=SensorStateClass.MEASUREMENT,
         suggested_unit_of_measurement=UnitOfPressure.KPA,
@@ -329,6 +333,7 @@ def __get_next_mode_change_timestamp(
         get_value_fn=__get_value_fn_sensor_value_default,
     ),
     SensorType.CO2: ACInfinitySensorSensorEntityDescription(
+        key="co2Sensor",
         device_class=SensorDeviceClass.CO2,
         state_class=SensorStateClass.MEASUREMENT,
         native_unit_of_measurement=CONCENTRATION_PARTS_PER_MILLION,
@@ -339,6 +344,7 @@ def __get_next_mode_change_timestamp(
         get_value_fn=__get_value_fn_sensor_value_default,
     ),
     SensorType.LIGHT: ACInfinitySensorSensorEntityDescription(
+        key="lightSensor",
         device_class=SensorDeviceClass.ILLUMINANCE,
         state_class=SensorStateClass.MEASUREMENT,
         native_unit_of_measurement=LIGHT_LUX,

diff --git a/custom_components/ac_infinity/strings.json b/custom_components/ac_infinity/strings.json
@@ -185,6 +185,12 @@
       "external_vapor_pressure_deficit": {
         "name": "External VPD"
       },
+      "co2_sensor": {
+        "name": "CO2"
+      },
+      "light_sensor": {
+        "name": "Light Level"
+      },
       "current_power": {
         "name": "Current Power"
       },

diff --git a/custom_components/ac_infinity/translations/en.json b/custom_components/ac_infinity/translations/en.json
@@ -186,6 +186,12 @@
       "external_vapor_pressure_deficit": {
         "name": "External VPD"
       },
+      "co2_sensor": {
+        "name": "CO2"
+      },
+      "light_sensor": {
+        "name": "Light Level"
+      },
       "current_power": {
         "name": "Current Power"
       },

diff --git a/tests/test_core.py b/tests/test_core.py
@@ -312,7 +312,8 @@ async def test_get_device_all_device_meta_data_returns_empty_list(self, data):
         "dev_type,expected_model",
         [
             (11, "UIS Controller 69 Pro (CTR69P)"),
-            (18, "UIS CONTROLLER 69 Pro+ (CTR69Q)"),
+            (18, "UIS Controller 69 Pro+ (CTR69Q)"),
+            (20, "UIS Controller AI+ (CTR89Q)"),
             (3, "UIS Controller Type 3"),
         ],
     )