[WApps] Add ItemOpacity property #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-czaja
reviewed
Jul 10, 2020
| @@ -152,12 +152,12 @@ internal void AnimateShowPage(RotaryItemWrapper wrapper, bool isReverse = true, | |||
| rotaryItem.Position = new Position(pos.X + (isReverse ? 70 : -70), pos.Y); ; | |||
|
|
|||
| animationCore.AnimateTo(rotaryItem, "Position", pos, 167 + sTime, 84 + sTime + 334, alphaSineOut33); | |||
| animationCore.AnimateTo(rotaryItem, "Opacity", 1.0f, 167 + sTime, 84 + sTime + 334, alphaSineOut33); | |||
| animationCore.AnimateTo(rotaryItem, "Opacity", rotaryItem.ItemOpacity, 167 + sTime, 84 + sTime + 334, alphaSineOut33); | |||
There was a problem hiding this comment.
How about:
float previousOpacity = rotaryItem.Opacity;
rotaryItem.Opacity = 0.0f;
...
animationCore.AnimateTo(rotaryItem, "Opacity", previousOpacity, 167 + sTime, 84 + sTime + 334, alphaSineOut33);
huiyueun
force-pushed
the
NUI_Add_opacity_Property
branch
from
c392622 to
596c968
Compare
Signed-off-by: huiyu.eun <[email protected]>
p-czaja
reviewed
Jul 10, 2020
| } | ||
| set | ||
| { | ||
| itemOpacity = value; |
There was a problem hiding this comment.
+ Opacity = itemOpacity;
And after modifying test app it only then works:
- float opacity = last.Opacity != 0.5f ? 0.5f : 1.0f;
- last.Opacity = opacity;
+ float opacity = last.ItemOpacity != 0.5f ? 0.5f : 1.0f;^M
+ last.ItemOpacity = opacity;^M
rabbitfor
force-pushed
the
master
branch
2 times, most recently
from
e3c4c42 to
cd8f109
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: huiyu.eun [email protected]