Merge pull request #31 from dahong67/mttkrp-collect

Eagerly instantiate the matricized tensor in mttkrp
dahong67 · Nov 15, 2023 · 6a796a5 · 6a796a5
2 parents 1859ee2 + 0b164ca
commit 6a796a5
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/gcp-opt.jl b/src/gcp-opt.jl
@@ -181,7 +181,7 @@ function mttkrp(X, U, n)
     (N == ndims(X) && I == size(X)) || throw(DimensionMismatch("`X` and `U` do not have matching dimensions"))
 
     # Matricized tensor (in mode n)
-    Xn = reshape(PermutedDimsArray(X, [n; setdiff(1:N, n)]), size(X, n), :)
+    Xn = reshape(permutedims(X, [n; setdiff(1:N, n)]), size(X, n), :)
 
     # Khatri-Rao product (in mode n)
     Zn = similar(U[1], prod(I[setdiff(1:N, n)]), r)