Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bgrewriteaof #95

Merged
merged 7 commits into from
Jan 6, 2025
Merged

Bgrewriteaof #95

merged 7 commits into from
Jan 6, 2025

Conversation

ArtemIsmagilov
Copy link
Contributor

Hi! I added BGREWRITEAOF high level command
https://redis.io/docs/latest/commands/bgrewriteaof/

@mcatanzariti
Copy link
Member

Hello,

The test is failing

stderr:
thread 'main' panicked at src/commands/server_commands.rs:15:1:
assertion `left == right` failed
  left: "Background append only file rewriting started"
 right: "Background append only file rewriting scheduled"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

ArtemIsmagilov and others added 5 commits January 6, 2025 00:41
@ArtemIsmagilov
Response statuses may be:
0f7eb0d 
- Background append only file rewriting `started`
- Background append only file rewriting `scheduled`
@ArtemIsmagilov
Update server_commands.rs
a596d3d
@ArtemIsmagilov
Update server_commands.rs
40d4a21 
HELP commands accurately return static text; serialization is not required for them and can be removed in the future.

But this command may still conflict when running in parallel
@ArtemIsmagilov
try scheduling saving file
c2cb024
@ArtemIsmagilov
use schedule method
945b625
@mcatanzariti mcatanzariti merged commit ad2b990 into dahomey-technologies:main Jan 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArtemIsmagilov @mcatanzariti