[ui] Allow freeform schedule/sensor name in launched-by Runs filter #27288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
hellendag
force-pushed
the
dish/fe-758-separate
branch
from
adda730 to
947d09f
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
js_modules/dagster-ui/packages/ui-core/src/ui/BaseFilters/useSuggestionFilter.tsx
Outdated
Show resolved
Hide resolved
hellendag
force-pushed
the
dish/fe-758-separate
branch
from
947d09f to
d62085a
Compare
|
Mind updating the tests for useSuggestionFilter.tsx |
hellendag
force-pushed
the
dish/fe-758-separate
branch
from
d62085a to
31d0b57
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 31d0b57. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We don't show all possible schedules and sensors in the "Launched by" filter on Runs, as we limit which results come from the backend, and schedules/sensors that don't exist in the current workspace aren't available.
To provide a fallback option for searching for schedules/sensors that are otherwise not available, show freeform options.
To achieve this while maintaining the behavior of allowing only one launched-by value, I also added a couple of features to suggestion filters that didn't previously exist:
allowMultipleSelectionsproperty, like with the static set filterfreeformResultPositionto allow customizing whether to show results at the top or bottom of the list.How I Tested These Changes
View Runs, verify that typing a value in the "Launched by" filter will provide me with two options, a schedule and a sensor. Choose each, verify that filtering behaves correctly.
Changelog
[ui] When viewing Runs, allow freeform search for filtering to view runs launched by schedules and sensors.