[pythonic config] properly propagate default values set at the top level for nested config classes #27206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vel for nested config classes
This stack of pull requests is managed by Graphite. Learn more about stacking. |
prha
approved these changes
Jan 28, 2025
prha
pushed a commit
that referenced
this pull request
Jan 29, 2025
…vel for nested config classes (#27206) ## Summary Ensures that default values on Pythonic Config get properly propagated to inner Config classes, e.g. ```python class ANestedOpConfig(Config): an_int: int = 1 a_bool: bool = True class AnOpConfig(Config): a_string: str = "foo" a_nested: ANestedOpConfig = ANestedOpConfig(an_int=5) ``` An alternative impl which uses some utils in a stacked PR can be found at #27209. ## Test Plan New unit test; todo add a few more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensures that default values on Pythonic Config get properly propagated to inner Config classes, e.g.
An alternative impl which uses some utils in a stacked PR can be found at #27209.
Test Plan
New unit test; todo add a few more