feat: Actions and streaming standard libraries #6074
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-streaming-stdlibs
…-streaming-stdlibs # Conflicts: # Source/DafnyStandardLibraries/src/Std/Collections/Seq.dfy
…-streaming-stdlibs
…/dafny into actions-and-streaming-stdlibs
robin-aws
changed the title
robin-aws
commented
Jan 24, 2025
| @@ -774,6 +774,25 @@ module Std.Collections.Seq { | |||
| } | |||
| } | |||
|
|
|||
| lemma {:induction false} LemmaMapPartialFunctionDistributesOverConcat<T,R>(f: (T --> R), xs: seq<T>, ys: seq<T>) | |||
There was a problem hiding this comment.
I found this was necessary because MapPartialFunction was introduced, not sure if there's a better solution?
RustanLeino
reviewed
Jan 24, 2025
| ghost predicate Valid() | ||
| reads this, Repr | ||
| ensures Valid() ==> this in Repr | ||
| ensures Valid() ==> CanProduce(history) |
There was a problem hiding this comment.
(This is the first occurrences of CanProduce I see, so maybe the answer to my thought will be clear to me later, but) my first impression is that CanProduce ought to be separate from Valid
| && nextValue == |history| | ||
| } | ||
|
|
||
| constructor() |
There was a problem hiding this comment.
Code style: constructor() looks like JavaScript to me. I would have written it with a space before the (), just like a named constructor constructor Init() but with an empty-string name.
| for enumerated := 0 to 5 | ||
| invariant e.Valid() | ||
| invariant enumerated == |e.history| | ||
| invariant fresh(e.Repr - old@before(e.Repr)) |
There was a problem hiding this comment.
Is old@before(e.Repr) all fresh as well? If so, you could just write fresh(e.Repr).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Still WIP but worth a first review pass)
What was changed?
See documentation.
How has this been tested?
See ActionsExamples.dfy etc.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.