Skip to content

Commit

Permalink
UI: Align all toolbar heights with contextual action mode heights
Browse files Browse the repository at this point in the history
  • Loading branch information
d4rken committed Nov 28, 2023
1 parent 4e1143b commit 6a3e1a8
Show file tree
Hide file tree
Showing 29 changed files with 34 additions and 33 deletions.
1 change: 1 addition & 0 deletions app/src/foss/res/layout/upgrade_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Surface"
android:layout_width="0dp"
android:minHeight="?actionBarSize"
android:layout_height="wrap_content"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
Expand Down
1 change: 1 addition & 0 deletions app/src/gplay/res/layout/upgrade_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Surface"
android:layout_width="0dp"
android:minHeight="?actionBarSize"
android:layout_height="wrap_content"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/layout/analyzer_app_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
android:layout_width="0dp"
android:minHeight="?actionBarSize"
android:layout_height="wrap_content"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/analyzer_apps_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="0dp"
android:layout_height="wrap_content"
app:layout_constraintEnd_toEndOf="parent"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/analyzer_content_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="0dp"
android:layout_height="wrap_content"
app:layout_constraintEnd_toEndOf="parent"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/analyzer_device_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="0dp"
android:layout_height="wrap_content"
app:layout_constraintEnd_toEndOf="parent"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/analyzer_storage_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="0dp"
android:layout_height="wrap_content"
app:layout_constraintEnd_toEndOf="parent"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/appcleaner_details_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="match_parent"
android:layout_height="wrap_content"
app:subtitle="@string/general_details_label"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/appcleaner_list_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="0dp"
android:layout_height="wrap_content"
app:layout_constraintEnd_toEndOf="parent"
Expand Down
3 changes: 1 addition & 2 deletions app/src/main/res/layout/appcontrol_list_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Toolbar"
style="@style/SDMToolbar.Primary"
android:layout_width="0dp"
android:layout_height="wrap_content"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/corpsefinder_details_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="match_parent"
android:layout_height="wrap_content"
app:subtitle="@string/general_details_label"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/corpsefinder_list_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="0dp"
android:layout_height="wrap_content"
app:layout_constraintEnd_toEndOf="parent"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/data_areas_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="0dp"
android:layout_height="wrap_content"
app:layout_constraintEnd_toEndOf="parent"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/debug_logview_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="0dp"
android:layout_height="wrap_content"
app:layout_constraintEnd_toEndOf="parent"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/deduplicator_details_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="match_parent"
android:layout_height="wrap_content"
app:subtitle="@string/general_details_label"
Expand Down
3 changes: 1 addition & 2 deletions app/src/main/res/layout/deduplicator_list_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="0dp"
android:layout_height="wrap_content"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:menu="@menu/menu_deduplicator_list"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/exclusion_editor_path_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="match_parent"
android:layout_height="wrap_content"
app:menu="@menu/menu_exclusion_editor_path"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/exclusion_editor_pkg_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="match_parent"
android:layout_height="wrap_content"
app:menu="@menu/menu_exclusion_editor_pkg"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="match_parent"
android:layout_height="wrap_content"
app:menu="@menu/menu_exclusion_editor_pkg"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/exclusion_list_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="match_parent"
android:layout_height="wrap_content"
app:menu="@menu/menu_exclusions_list"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/scheduler_manager_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="0dp"
android:layout_height="wrap_content"
app:layout_constraintEnd_toEndOf="parent"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/settings_base_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="match_parent"
android:layout_height="wrap_content"
app:layout_constraintEnd_toEndOf="parent"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/settings_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="match_parent"
android:layout_height="wrap_content"
app:layout_constraintEnd_toEndOf="parent"
Expand Down
3 changes: 2 additions & 1 deletion app/src/main/res/layout/setup_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
style="@style/Widget.MaterialComponents.Toolbar.Surface"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:minHeight="?actionBarSize"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
Expand All @@ -35,10 +36,10 @@

<androidx.recyclerview.widget.RecyclerView
android:id="@+id/list"
style="@style/BaseRecyclerList"
android:layout_width="match_parent"
android:layout_height="0dp"
android:clipToPadding="false"
style="@style/BaseRecyclerList"
android:paddingVertical="4dp"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="match_parent"
android:layout_height="wrap_content"
app:menu="@menu/menu_systemcleaner_customfilter_editor"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="match_parent"
android:layout_height="wrap_content"
app:menu="@menu/menu_systemcleaner_customfilter_list"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/systemcleaner_details_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="match_parent"
android:layout_height="wrap_content"
app:subtitle="@string/general_details_label"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/systemcleaner_list_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<com.google.android.material.appbar.MaterialToolbar
android:id="@+id/toolbar"
style="@style/Widget.MaterialComponents.Toolbar.Primary"
style="@style/SDMToolbar.Primary"
android:layout_width="0dp"
android:layout_height="wrap_content"
app:layout_constraintEnd_toEndOf="parent"
Expand Down
11 changes: 5 additions & 6 deletions app/src/main/res/values/styles.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<resources>

<style name="DashboardCardItem" parent="Widget.Material3.CardView.Elevated">
<item name="android:layout_marginTop">4dp</item>
<item name="android:layout_marginBottom">4dp</item>
Expand Down Expand Up @@ -27,11 +26,6 @@
<item name="iconPadding">4dp</item>
</style>

<style name="Toolbar" parent="@style/Widget.MaterialComponents.Toolbar.Primary">
<item name="android:layout_height">?actionBarSize</item>
<item name="android:layout_width">match_parent</item>
</style>

<style name="BaseRecyclerList">
<item name="android:fastScrollEnabled">false</item>
<item name="fastScrollEnabled">false</item>
Expand Down Expand Up @@ -186,4 +180,9 @@
<item name="cornerSize">32dp</item>
</style>

<style name="SDMToolbar.Primary" parent="Widget.MaterialComponents.Toolbar.Primary">
<item name="android:layout_height">wrap_content</item>
<item name="android:minHeight">?actionBarSize</item>
</style>

</resources>

0 comments on commit 6a3e1a8

Please sign in to comment.