Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for different states in notification text #210

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Implement support for different states in notification text #210

merged 1 commit into from
Jun 27, 2024

Conversation

rcky844
Copy link

@rcky844 rcky844 commented Jun 27, 2024

Fixes #198

@rcky844
Copy link
Author

rcky844 commented Jun 27, 2024 •
edited
Loading

@d4rken d4rken added the enhancement Add a new feature of improve an existing feature label Jun 27, 2024
d4rken
d4rken approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

How I could test this? When I use it, it shows the collapsed notification containing the battery percentages, not the content title.

When is only the title being shown?

app/src/main/java/eu/darken/capod/monitor/ui/MonitorNotifications.kt Show resolved Hide resolved
@d4rken
Copy link
Member

d4rken commented Jun 27, 2024

I can't seem to get the minimized notification (#198) on my phone 🤔

@d4rken d4rken merged commit 07a1179 into d4rken-org:main Jun 27, 2024
7 checks passed
@rcky844
Copy link
Author

rcky844 commented Jun 27, 2024 •
edited
Loading

I can't seem to get the minimized notification (#198) on my phone 🤔

What Android version is it on?

I actually have a patch in #211

@d4rken
Copy link
Member

d4rken commented Jun 27, 2024

I tried it on Android 14 and 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4rken d4rken d4rken approved these changes

Assignees
No one assigned
Labels
enhancement Add a new feature of improve an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notification shows wrong text when minimized
2 participants
@rcky844 @d4rken